Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect ECAL time reconstruction for events without EB [14.0.x] #45313

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Protect ECAL time reconstruction for events without EB [14.0.x] #45313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions RecoLocalCalo/EcalRecProducers/plugins/alpaka/EcalUncalibRecHitMultiFitAlgoPortable.dev.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,20 +118,22 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE::ecal::multifit {
// TODO: small kernel only for EB. It needs to be checked if
/// fusing such small kernels is beneficial in here
//
// we are running only over EB digis
// therefore we need to create threads/blocks only for that
auto const threadsFixMGPA = threads_1d;
auto const blocksFixMGPA = cms::alpakatools::divide_up_by(kMaxSamples * ebSize, threadsFixMGPA);
auto workDivTimeFixMGPAslew1D = cms::alpakatools::make_workdiv<Acc1D>(blocksFixMGPA, threadsFixMGPA);
alpaka::exec<Acc1D>(queue,
workDivTimeFixMGPAslew1D,
Kernel_time_compute_fixMGPAslew{},
digisDevEB.const_view(),
digisDevEE.const_view(),
conditionsDev.const_view(),
scratch.sample_valuesDevBuf.value().data(),
scratch.sample_value_errorsDevBuf.value().data(),
scratch.useless_sample_valuesDevBuf.value().data());
if (ebSize > 0) {
// we are running only over EB digis
// therefore we need to create threads/blocks only for that
auto const threadsFixMGPA = threads_1d;
auto const blocksFixMGPA = cms::alpakatools::divide_up_by(kMaxSamples * ebSize, threadsFixMGPA);
auto workDivTimeFixMGPAslew1D = cms::alpakatools::make_workdiv<Acc1D>(blocksFixMGPA, threadsFixMGPA);
alpaka::exec<Acc1D>(queue,
workDivTimeFixMGPAslew1D,
Kernel_time_compute_fixMGPAslew{},
digisDevEB.const_view(),
digisDevEE.const_view(),
conditionsDev.const_view(),
scratch.sample_valuesDevBuf.value().data(),
scratch.sample_value_errorsDevBuf.value().data(),
scratch.useless_sample_valuesDevBuf.value().data());
}

auto const threads_nullhypot = threads_1d;
auto const blocks_nullhypot = blocks_1d;
Expand Down