Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect ECAL time reconstruction for events without EB [14.0.9-patchX] #45314

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 26, 2024

PR description:

Protect the ECAL time reconstruction for events without any rechits in the ECAL barrel.

PR validation:

Fixes HLT crashes observed in run 382460, described in #45312.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45311 to 14.0.9-patchX for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

backport #45311

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

type ecal

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_9_patchX.

It involves the following packages:

  • RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
Note that this branch is designed for requested bug fixes specific to the CMSSW_14_0_9 release.
If you wish to make a pull request for the CMSSW_14_0_X release cycle, please use the CMSSW_14_0_X branch instead

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2024

cms-bot internal usage

@cmsbuild cmsbuild added the ecal label Jun 26, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 26, 2024

Same as #45313 in case we need an urgent fix in the CMSSW_14_0_9_patchX branch.

@fwyzard fwyzard changed the title Protect ECAL unpacker for events without EB [14.0.9-patchX] Protect ECAL time reconstruction for events without EB [14.0.9-patchX] Jun 26, 2024
@fwyzard fwyzard force-pushed the fix_EcalUncalibRecHitMultiFitAlgo_empty_EB_140x branch from d0f844f to fef0757 Compare June 26, 2024 13:18
@cmsbuild
Copy link
Contributor

Pull request #45314 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

+1
oops I triggered the tests by reflex, but it clearly makes no sense here.
In any case, this is basically a one-liner verbatim backport

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_9_patchX IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Jun 27, 2024
@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e00c728 into cms-sw:CMSSW_14_0_9_patchX Jun 27, 2024
15 of 16 checks passed
@fwyzard fwyzard deleted the fix_EcalUncalibRecHitMultiFitAlgo_empty_EB_140x branch November 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants