-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lost Dict Def: Add HcalRecHitSoA for HcalRecHit package #45298
Conversation
test parameters:
|
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45298/40707
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @makortel, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
yes @mmusich , back porting it should fix the 14.0.X QA failures too. I will open a PR for 14.0.X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-259a17/40063/summary.html Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 . please review this? This should fix the failing QA lost dictionaries tests |
+1 |
Many thanks Shahzad. |
This fixes the lost dictionary definition errors we see in IBs (https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py/el8_amd64_gcc12/www/fri/14.1-fri-11/CMSSW_14_1_X_2024-06-21-1100/testLogs/dupDict-lostDefs.log) and PR tests. New dictionaries were added via https://github.com/cms-sw/cmssw/pull/45199/files but mapping was missing for these new dict in Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py