Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost Dict Def: Add HcalRecHitSoA for HcalRecHit package #45298

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 25, 2024

This fixes the lost dictionary definition errors we see in IBs (https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py/el8_amd64_gcc12/www/fri/14.1-fri-11/CMSSW_14_1_X_2024-06-21-1100/testLogs/dupDict-lostDefs.log) and PR tests. New dictionaries were added via https://github.com/cms-sw/cmssw/pull/45199/files but mapping was missing for these new dict in Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = DataFormats/HcalRecHit

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

cms-bot internal usage

@smuzaffar smuzaffar changed the title Fix lostDict: Add HcalRecHitSoA for HcalRecHit package Fix lost Dict Def: Add HcalRecHitSoA for HcalRecHit package Jun 25, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45298/40707

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Utilities/ReleaseScripts (core)

@Dr15Jones, @makortel, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@mmusich
Copy link
Contributor

mmusich commented Jun 25, 2024

as #45199 was backported (#45277) do we need a backport of this as well?

@smuzaffar
Copy link
Contributor Author

yes @mmusich , back porting it should fix the 14.0.X QA failures too. I will open a PR for 14.0.X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-259a17/40063/summary.html
COMMIT: 3f87e3f
CMSSW: CMSSW_14_1_X_2024-06-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45298/40063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345062
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 . please review this? This should fix the failing QA lost dictionaries tests

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

@cms-sw/orp-l2 . please review this? This should fix the failing QA lost dictionaries tests

Many thanks Shahzad.

@cmsbuild cmsbuild merged commit 6f4c1fd into cms-sw:master Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants