Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalRecHit SoA DataFormats [14.0.x] #45277

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 20, 2024

PR description:

Quoting @kakwok:

A subset of changes from #44910, including only the data format changes for HcalRecHit SoA output.
Since the output data format is stable, this PR allows @jsamudio in parallel to develop for the changes on the PF cluster side to use HcalRecHit SoA as input.

PR validation:

Tested together with #45278.

Technical-only changes, validated running the HLT over 100k events, and obtaining identical results.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45199.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/HcalRecHit (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @bsunanda, @rovere, @missirol, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 20, 2024

type hcal

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 20, 2024

backport #45199

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 20, 2024

assign heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 20, 2024

+heterogeneous

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 20, 2024

please test

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with #45278, please check if they should be merged together

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d23357/39998/summary.html
COMMIT: 9e90e2b
CMSSW: CMSSW_14_0_X_2024-06-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45277/39998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342429
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #45278, please check if they should be merged together

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cfd8f28 into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
@fwyzard fwyzard deleted the Mahi-alpaka_DataFormat_14_0_9 branch June 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants