Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect DQMEventInfo when there is no PoolDBESSource@GlobalTag PSet in the process history #45286

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 24, 2024

PR description:

The goal of this PR is to fix a problem that was created by PR #45255 and seen in IBs (e.g. in the unit test of the package DQM/BeamMonitor, see e.g. log).
Commit 348c6f5 protects the case in which there is no GlobalTag parameter in the processing (e.g. an EmptySource was used) and as such the PoolDBESSource@GlobalTag PSet is missing and cannot be found to fill a monitor element.
I profit of this PR to fix another mistake introduced in #45255 in commit 29c499d (not intended to show by default the HLT GT, but only in selected cases)

PR validation:

Run successfully with this branch: scram b runtests_testOnlineBeamMonitor

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported at #45282

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45286/40683

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMServices/Components (dqm)

@cmsbuild, @antoniovagnerini, @tjavaid, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

test parameters:

  • addpkg = DQM/BeamMonitor

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Jun 24, 2024

urgent

  • to fix IB unit tests

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cca5e/40026/summary.html
COMMIT: 348c6f5
CMSSW: CMSSW_14_1_X_2024-06-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45286/40026/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Jun 25, 2024

Hi @smuzaffar , the Error warnings for the Duplicate Dictionaries in the tests are just because of some glitch or something needs to be fixed in the PR? (same also goes for #45287). Thanks!

@smuzaffar
Copy link
Contributor

@tjavaid , the dict errors[a] are not related to this PR. These issues are already in IBs and these were first introduced by #45199

[a]

./DataFormats/HcalRecHit/src/classes_def.xml
  HcalRecHitSoA : hcal::HcalRecHitSoA
  HcalRecHitSoA : hcal::HcalRecHitSoA::View

@smuzaffar
Copy link
Contributor

@tjavaid , #45298 should fix lost dict def issue. Note that #45286 and #45287 has nothing to do with this error so you can signed these PRs

@tjavaid
Copy link

tjavaid commented Jun 25, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eee1675 into cms-sw:master Jun 25, 2024
12 checks passed
@mmusich mmusich deleted the mm_fix_DQM_BeamMonitor branch June 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants