-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect DQMEventInfo
when there is no PoolDBESSource@GlobalTag
PSet
in the process history
#45286
Conversation
type bug-fix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45286/40683
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @antoniovagnerini, @tjavaid, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
urgent
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cca5e/40026/summary.html Comparison SummarySummary:
|
Hi @smuzaffar , the Error warnings for the Duplicate Dictionaries in the tests are just because of some glitch or something needs to be fixed in the PR? (same also goes for #45287). Thanks! |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is to fix a problem that was created by PR #45255 and seen in IBs (e.g. in the unit test of the package
DQM/BeamMonitor
, see e.g. log).Commit 348c6f5 protects the case in which there is no
GlobalTag
parameter in the processing (e.g. anEmptySource
was used) and as such thePoolDBESSource@GlobalTag
PSet is missing and cannot be found to fill a monitor element.I profit of this PR to fix another mistake introduced in #45255 in commit 29c499d (not intended to show by default the HLT GT, but only in selected cases)
PR validation:
Run successfully with this branch:
scram b runtests_testOnlineBeamMonitor
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it will be backported at #45282