Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQMEventInfo: add the possibility to register the GlobalTag name in a MonitorElement #45255

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 18, 2024

PR description:

The goal of this PR is to equip DQMEventInfo to add the possibility to register the GlobalTag in a TString MonitorElement. (as already done by DQMProvInfo).
This can be used to make dqmEnvHLT and dqmInfoHLTMon show the last HLT processing GlobalTag. This was requested at CMSHLT-3266.

PR validation:

Run runTheMatrix.py -l 141.042 -t 4 -j 8 and then inspected the resulting DQM file:

Screenshot from 2024-06-18 15-23-02

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but might be backported to CMSSW_14_0_X for 2024 data-taking purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45255/40637

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • DQMServices/Components (dqm)

@syuvivida, @cmsbuild, @rvenditti, @tjavaid, @antoniovagnerini, @nothingface0 can you please review it and eventually sign? Thanks.
@barvic, @Fedespring, @rociovilar, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @mtosi this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-238fdd/39948/summary.html
COMMIT: ad77ac5
CMSSW: CMSSW_14_1_X_2024-06-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45255/39948/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344992
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.235 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.048 KiB L1T/L1TriggerVsReco
  • DQMHistoSizes: changed ( 1000.0,... ): 0.037 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.036 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.035 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.034 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.033 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): 0.032 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0a8a2a8 into cms-sw:master Jun 21, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_HLT-GlobalTag_DQMEventInfo branch June 21, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants