-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL - Roll back to ECAL ratio timing for Run 3 - 140X #45157
ECAL - Roll back to ECAL ratio timing for Run 3 - 140X #45157
Conversation
…activate CC timing.
A new Pull Request was created by @thomreis for CMSSW_14_0_X. It involves the following packages:
@mandrenguyen, @cmsbuild, @fabiocos, @rappoccio, @jfernan2, @davidlange6, @antoniovilela can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
type ecal |
backport of #45155 |
please test |
urgent
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39b4b8/39755/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged. |
In the interest of time we will merge this without the main branch IB tests since these tests were successful. |
PR description:
Due to issues observed with the ECAL ratio timing at high pT [1] we are rolling back to the ratio timing algorithm.
To achieve this the
run3_ecal
modifier which used to activate the CC timing algorithm in Run 3 was replaced with a new modifierecal_cctiming
that explicitly activates the algorithm. The new modifier is not used in therun3
era though and so the default ratio timing algorithm is used in Run 3 reconstruction.The change can run out of the box with the current prompt and express GTs but for better handling a new prompt tag with the calibrations and a new express tag with the offsets for ratio timing will be prepared to replace the HLT tags in the GTs.
[1] https://indico.cern.ch/event/1424192/contributions/5990405/attachments/2872238/5028943/ecal_cctiming_ppd_20240606.pdf
PR validation:
No syntax errors in python configuration. Code compiles.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #45155