Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL - Roll back to ECAL ratio timing for Run 3 - 140X #45157

Merged

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Jun 6, 2024

PR description:

Due to issues observed with the ECAL ratio timing at high pT [1] we are rolling back to the ratio timing algorithm.
To achieve this the run3_ecal modifier which used to activate the CC timing algorithm in Run 3 was replaced with a new modifier ecal_cctiming that explicitly activates the algorithm. The new modifier is not used in the run3 era though and so the default ratio timing algorithm is used in Run 3 reconstruction.

The change can run out of the box with the current prompt and express GTs but for better handling a new prompt tag with the calibrations and a new express tag with the offsets for ratio timing will be prepared to replace the HLT tags in the GTs.

[1] https://indico.cern.ch/event/1424192/contributions/5990405/attachments/2872238/5028943/ecal_cctiming_ppd_20240606.pdf

PR validation:

No syntax errors in python configuration. Code compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45155

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

A new Pull Request was created by @thomreis for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • RecoLocalCalo/EcalRecProducers (reconstruction)

@mandrenguyen, @cmsbuild, @fabiocos, @rappoccio, @jfernan2, @davidlange6, @antoniovilela can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @thomreis, @wang0jin, @rchatter, @Martin-Grunewald, @makortel, @argiro, @missirol, @youyingli, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

cms-bot internal usage

@thomreis
Copy link
Contributor Author

thomreis commented Jun 6, 2024

type ecal

@thomreis
Copy link
Contributor Author

thomreis commented Jun 6, 2024

backport of #45155

@thomreis
Copy link
Contributor Author

thomreis commented Jun 6, 2024

please test

@malbouis
Copy link
Contributor

malbouis commented Jun 6, 2024

urgent

  • we would like to have this in prompt reconstruction by the end of the technical stop in June 15th as outlined in the PPD News, slide 13 from today's PPD General.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39b4b8/39755/summary.html
COMMIT: 90c5dcb
CMSSW: CMSSW_14_0_X_2024-06-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45157/39755/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 6364 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 4818
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 3333855
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.07 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.043 ): 0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.004 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@mandrenguyen
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 3f5342c into cms-sw:CMSSW_14_0_X Jun 7, 2024
10 checks passed
@rappoccio
Copy link
Contributor

In the interest of time we will merge this without the main branch IB tests since these tests were successful.

@thomreis thomreis deleted the ecal-rollback-to-ratio-timing-140x branch June 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants