Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL - Roll back to ECAL ratio timing for Run 3 - 140X #45157

Merged
merged 1 commit into from
Jun 7, 2024
Merged

ECAL - Roll back to ECAL ratio timing for Run 3 - 140X #45157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Configuration/ProcessModifiers/python/ecal_cctiming_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import FWCore.ParameterSet.Config as cms

# This modifier is for the ECAL Cross-Correlation timing algorithm

ecal_cctiming = cms.Modifier()

6 changes: 3 additions & 3 deletions RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

# use CC timing method for Run3 and Phase 2 (carried over from Run3 era)
import FWCore.ParameterSet.Config as cms
from Configuration.Eras.Modifier_run3_ecal_cff import run3_ecal
run3_ecal.toModify(ecalMultiFitUncalibRecHit,
from Configuration.ProcessModifiers.ecal_cctiming_cff import ecal_cctiming
ecal_cctiming.toModify(ecalMultiFitUncalibRecHit,
algoPSet = dict(timealgo = 'crossCorrelationMethod',
EBtimeNconst = 25.5,
EBtimeConstantTerm = 0.85,
Expand All @@ -19,7 +19,7 @@
)
)

# this overrides the modifications made by run3_ecal if both modifiers are active
# this overrides the modifications made by the ecal_cctiming modifier if both modifiers are active
from Configuration.ProcessModifiers.gpuValidationEcal_cff import gpuValidationEcal
gpuValidationEcal.toModify(ecalMultiFitUncalibRecHit,
algoPSet = dict(timealgo = 'RatioMethod',
Expand Down
6 changes: 3 additions & 3 deletions RecoLocalCalo/EcalRecProducers/python/ecalRecHit_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,13 @@
)

# use CC timing method for Run3 and Phase 2 (carried over from Run3 era)
from Configuration.Eras.Modifier_run3_ecal_cff import run3_ecal
run3_ecal.toModify(ecalRecHit,
from Configuration.ProcessModifiers.ecal_cctiming_cff import ecal_cctiming
ecal_cctiming.toModify(ecalRecHit,
timeCalibTag = ':CC',
timeOffsetTag = ':CC'
)

# this overrides the modifications made by run3_ecal if both modifiers are active
# this overrides the modifications made by ecal_cctiming if both modifiers are active
from Configuration.ProcessModifiers.gpuValidationEcal_cff import gpuValidationEcal
gpuValidationEcal.toModify(ecalRecHit,
timeCalibTag = ':',
Expand Down