Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL - Roll back to ECAL ratio timing for Run 3 #45155

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Jun 6, 2024

PR description:

Due to issues observed with the ECAL ratio timing at high pT [1] we are rolling back to the ratio timing algorithm.
To achieve this the run3_ecal modifier which used to activate the CC timing algorithm in Run 3 was replaced with a new modifierecal_cctiming that explicitly activates the algorithm. The new modifier is not used in the run 3 era though and so the default ratio timing algorithm is used in Run 3 reconstruction.

The change can run out of the box with the current prompt and express GTs but for better handling a new prompt tag with the calibrations and a new express tag with the offsets for ratio timing will be prepared to replace the HLT tags in the GTs.

[1] https://indico.cern.ch/event/1424192/contributions/5990405/attachments/2872238/5028943/ecal_cctiming_ppd_20240606.pdf

PR validation:

No syntax errors in python configuration. Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

cms-bot internal usage

@thomreis
Copy link
Contributor Author

thomreis commented Jun 6, 2024

type ecal

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45155/40499

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

A new Pull Request was created by @thomreis for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • RecoLocalCalo/EcalRecProducers (reconstruction)

@antoniovilela, @davidlange6, @rappoccio, @fabiocos, @mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@apsallid, @argiro, @fabiocos, @ReyerBand, @youyingli, @wang0jin, @thomreis, @Martin-Grunewald, @missirol, @makortel, @rchatter this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Jun 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7285f5/39754/summary.html
COMMIT: 67691a2
CMSSW: CMSSW_14_1_X_2024-06-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45155/39754/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 5762 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 4348
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 3334586
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.043 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.016 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@malbouis
Copy link
Contributor

malbouis commented Jun 6, 2024

urgent

@cmsbuild cmsbuild added the urgent label Jun 6, 2024
@mandrenguyen
Copy link
Contributor

+reconstruction
Comparisons look consistent to change of ECAL timing method + downstream effects.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1966fb7 into cms-sw:master Jun 7, 2024
11 checks passed
@thomreis thomreis deleted the ecal-rollback-to-ratio-timing branch June 7, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants