Update DDHGCalPassive.cc

[iarspider]

PR description:

Fix compiler warning in DBG_X IBs:

  src/Geometry/HGCalCommonData/plugins/DDHGCalPassive.cc:24: warning: "EDM_ML_DEBUG" redefined
    24 | #define EDM_ML_DEBUG
      | 

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_DBG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45171/40519

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Geometry/HGCalCommonData (upgrade, geometry)

@mdhildreth, @srimanob, @subirsarkar, @bsunanda, @civanch, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Shouldn't that #define just be commented out as we do not want debug statements running in production?

[iarspider]

Shouldn't that #define just be commented out as we do not want debug statements running in production?

@bsunanda

[civanch]

@iarspider , you simply remove ifdef and comment out debug statement - when it will be needed it will be uncommented.

[iarspider]

please test for CMSSW_14_1_DBG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45171/40521

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #45171 was updated. @Dr15Jones, @srimanob, @makortel, @civanch, @subirsarkar, @mdhildreth, @bsunanda can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3d96c/39783/summary.html
COMMIT: d8bb8ea
CMSSW: CMSSW_14_1_DBG_X_2024-06-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45171/39783/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @thomreis ECAL - Roll back to ECAL ratio timing for Run 3 #45155
• @CTPPS Run the T2 test with ROOT Raw instead of streamer files #45144

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3d96c/39783/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3d96c/39783/git-merge-result

Comparison Summary

Summary:

• You potentially added 9060036 lines to the logs
• Reco comparison results: 51883 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338974
• DQMHistoTests: Total failures: 101885
• DQMHistoTests: Total nulls: 91
• DQMHistoTests: Total successes: 3236978
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.9210000000000003 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.063 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 1.443 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.043 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.020 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): 0.109 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.293 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.287 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 12 / 46 workflows

[civanch]

+1

Observed differences with the baseline are not connected with this PR.

[srimanob]

Hi @Dr15Jones @iarspider @civanch

Clearly, we need to turn this EDM_ML_DEBUG off to avoid printout in production.

However, I am not sure I understand why we get the warning,
warning: "EDM_ML_DEBUG" redefined
where it is defined first? With the warning, it seems it is defined somewhere, so turn it off or not will not change the output.

Thx.

[iarspider]

However, I am not sure I understand why we get the warning, warning: "EDM_ML_DEBUG" redefined where it is defined first? With the warning, it seems it is defined somewhere, so turn it off or not will not change the output.

For DBG_X IBs (where this warning was spotted) we explicitly define this symbol in command-line.

[srimanob]

+Upgrade

Thanks @iarspider

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[iarspider]

@cms-sw/orp-l2 gentle ping

[rappoccio]

+1