-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing header in StreamerInputModule.h #45110
Conversation
Made header consistent.
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45110/40436
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @smuzaffar, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
This needs to be added to #44978 too, right? Whereas the test release CMSSW_14_0_7_HLTTest discussed in #45081 (comment) should be fine, as no further developments are planned on top of that. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c21b3/39634/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
I don't think we apply the header consistency checks in older releases. The above PR is only needed for that check, all code already compiles fine. |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Made header consistent.
PR validation:
Code compiles.
This showed up as a test failure in #45096.