Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable in VertexTimeAlgorithmLegacy4D.cc #45093

Merged
merged 1 commit into from
May 30, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Fixes the following compilation warning:

  src/RecoVertex/PrimaryVertexProducer/src/VertexTimeAlgorithmLegacy4D.cc:29:10: warning: variable 'sumwt2' set but not used [-Wunused-but-set-variable]
    29 |   double sumwt2 = 0.;
      |          ^
1 warning generated.

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45093/40413

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • RecoVertex/PrimaryVertexProducer (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@rovere, @JanFSchulte, @VinInn, @GiacomoSguazzoni, @dgulhan, @missirol, @mmusich, @fabiocos, @mtosi, @VourMa this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-442c5b/39602/summary.html
COMMIT: fef8047
CMSSW: CMSSW_14_1_X_2024-05-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45093/39602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3445370
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3445344
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-442c5b/39603/summary.html
COMMIT: fef8047
CMSSW: CMSSW_14_1_CLANG_X_2024-05-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45093/39603/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14509 lines to the logs
  • Reco comparison results: 31068 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3445370
  • DQMHistoTests: Total failures: 38161
  • DQMHistoTests: Total nulls: 154
  • DQMHistoTests: Total successes: 3407035
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.026999999999999993 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 4 / 47 workflows

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants