MuonHLTSeedMVAClassifier: update to use MVA-related parameters according to isL1 value

[mmusich]

PR description:

In CMSHLT-3197 it was discussed to avoid loading to HLT configuration parameters that are unneeded by looking into improving the plugin MuonHLTSeedMVAClassifier.
For example, isFromL1 is needed, but there is no need to have separate *L1 and *L2 parameters, since the plugin only ever uses one set (*L1 or *L2) based on the value of isFromL1. The following list of parameters is enough,

• isFromL1
• mvaFileB
• mvaFileE
• mvaScaleMeanB
• mvaScaleStdB
• mvaScaleMeanE
• mvaScaleStdE

provided one configures every module correctly. A check is added throwing an exception in case the MVA model is not compatible with the value of isFromL1.

PR validation:

addOnTests.py runs fine with this PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported to CMSSW_14_0_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45063/40376

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoMuon/TrackerSeedGenerator (reconstruction)

@mmusich, @jfernan2, @mandrenguyen, @Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@JanFSchulte, @rociovilar, @silviodonato, @cericeci, @bellan, @jhgoh, @trocino, @andrea21z, @HuguesBrun, @CeliaFernandez, @abbiendi, @Martin-Grunewald, @missirol, @Fedespring this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@wonpoint4 @fmanteca FYI

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba506a/39557/summary.html
COMMIT: e2e21e7
CMSSW: CMSSW_14_1_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45063/39557/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 857
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337985
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45063/40380

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[cmsbuild]

Pull request #45063 was updated. @jfernan2, @Martin-Grunewald, @mmusich, @cmsbuild, @mandrenguyen can you please check and sign again.

[cmsbuild]

Pull request #45063 was updated. @mmusich, @cmsbuild, @Martin-Grunewald, @jfernan2, @mandrenguyen can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45063/40402

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba506a/39592/summary.html
COMMIT: fb54b44
CMSSW: CMSSW_14_1_X_2024-05-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45063/39592/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338836
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• relval workflows and addOnTests pass, no relevant differences in DQMHistoTests nor in TriggerResults.

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1