(DAQ) remove dummy MicroStateService #44991

smorovic · 2024-05-16T21:37:23Z

PR description:

Removes dummy MicroStateService class and changes to using FastMonitoringService directly

PR validation:

Tested in DAQ test setup (online HLT emulation) with no issues seen.

cmsbuild · 2024-05-16T21:37:47Z

cms-bot internal usage

cmsbuild · 2024-05-16T21:42:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40271

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File EventFilter/Utilities/plugins/GlobalEvFOutputModule.cc modified in PR(s): Handle event meta data changes in streamer files #44892
- File EventFilter/Utilities/src/DAQSource.cc modified in PR(s): (DAQ) fix input source cv notification [14_1_X] #44979
- File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): Handle event meta data changes in streamer files #44892
- File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): Handle event meta data changes in streamer files #44892, (DAQ) fix input source cv notification [14_1_X] #44979
- File HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc modified in PR(s): (DAQ) jsoncpp moved to a namespace (14_1_X) #44989
- File HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc modified in PR(s): (DAQ) jsoncpp moved to a namespace (14_1_X) #44989

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40271/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40271/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-05-16T21:49:43Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40272

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File EventFilter/Utilities/plugins/GlobalEvFOutputModule.cc modified in PR(s): Handle event meta data changes in streamer files #44892
- File EventFilter/Utilities/src/DAQSource.cc modified in PR(s): (DAQ) fix input source cv notification [14_1_X] #44979
- File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): Handle event meta data changes in streamer files #44892
- File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): Handle event meta data changes in streamer files #44892, (DAQ) fix input source cv notification [14_1_X] #44979
- File HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc modified in PR(s): (DAQ) jsoncpp moved to a namespace (14_1_X) #44989
- File HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc modified in PR(s): (DAQ) jsoncpp moved to a namespace (14_1_X) #44989

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40272/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40272/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-05-16T21:55:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44991/40273

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File EventFilter/Utilities/plugins/GlobalEvFOutputModule.cc modified in PR(s): Handle event meta data changes in streamer files #44892
- File EventFilter/Utilities/src/DAQSource.cc modified in PR(s): (DAQ) fix input source cv notification [14_1_X] #44979
- File EventFilter/Utilities/src/EvFDaqDirector.cc modified in PR(s): Handle event meta data changes in streamer files #44892
- File EventFilter/Utilities/src/FedRawDataInputSource.cc modified in PR(s): Handle event meta data changes in streamer files #44892, (DAQ) fix input source cv notification [14_1_X] #44979
- File HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc modified in PR(s): (DAQ) jsoncpp moved to a namespace (14_1_X) #44989
- File HLTrigger/JSONMonitoring/plugins/L1TriggerJSONMonitoring.cc modified in PR(s): (DAQ) jsoncpp moved to a namespace (14_1_X) #44989

cmsbuild · 2024-05-16T21:55:45Z

A new Pull Request was created by @smorovic for master.

It involves the following packages:

DQMServices/FileIO (dqm)
EventFilter/Utilities (daq)
HLTrigger/JSONMonitoring (hlt)

@cmsbuild, @smorovic, @antoniovagnerini, @Martin-Grunewald, @emeschi, @rvenditti, @syuvivida, @nothingface0, @tjavaid, @mmusich can you please review it and eventually sign? Thanks.
@barvic, @Martin-Grunewald, @silviodonato, @fwyzard, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

smorovic · 2024-05-16T21:55:53Z

@cmsbuild please test with #44372 #44892 #44979 #44989

smorovic · 2024-05-16T21:58:24Z

@cmsbuild please test with #44372, #44892, #44979, #44989

smorovic · 2024-05-17T06:59:53Z

it is due to #44372

smorovic · 2024-05-17T07:00:07Z

hold

cmsbuild · 2024-05-17T07:00:14Z

Pull request has been put on hold by @smorovic
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

mmusich · 2024-05-17T07:01:44Z

it is due to #44372

@smorovic that PR needs more work, so feel free to remove it from your tests, I don't think it will be merged soon.

smorovic · 2024-05-17T07:02:51Z

unhold

smorovic · 2024-05-17T07:03:20Z

please test with #44892, #44979, #44989

(4472 is test only)

cmsbuild · 2024-05-17T09:48:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8a380/39419/summary.html
COMMIT: 7064618
CMSSW: CMSSW_14_1_X_2024-05-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44991/39419/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338976
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338953
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

smorovic · 2024-05-17T09:52:16Z

+daq

Martin-Grunewald · 2024-05-21T06:50:50Z

+1

tjavaid · 2024-05-23T14:20:22Z

+1

cmsbuild · 2024-05-23T14:20:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44892

rappoccio · 2024-05-29T15:40:21Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone May 16, 2024

cmsbuild added dqm-pending hlt-pending daq-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 16, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 16, 2024

removing mss

d050015

smorovic force-pushed the 141X-purge-mss branch from c0bc1da to d050015 Compare May 16, 2024 21:44

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 16, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 16, 2024

code-format

7064618

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 16, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 16, 2024

cmsbuild added tests-started and removed tests-pending labels May 16, 2024

cmsbuild added the hold label May 17, 2024

cmsbuild removed the hold label May 17, 2024

cmsbuild added tests-started and removed tests-rejected labels May 17, 2024

cmsbuild added tests-approved and removed tests-started labels May 17, 2024

cmsbuild added daq-approved and removed daq-pending labels May 17, 2024

cmsbuild added hlt-approved and removed hlt-pending labels May 21, 2024

cmsbuild mentioned this pull request May 22, 2024

Handle event meta data changes in streamer files #44892

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 23, 2024

cmsbuild added orp-approved and removed orp-pending labels May 29, 2024

cmsbuild merged commit 10ef3f1 into cms-sw:master May 29, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(DAQ) remove dummy MicroStateService #44991

(DAQ) remove dummy MicroStateService #44991

smorovic commented May 16, 2024

cmsbuild commented May 16, 2024 •

edited

Loading

cmsbuild commented May 16, 2024

cmsbuild commented May 16, 2024

cmsbuild commented May 16, 2024

cmsbuild commented May 16, 2024

smorovic commented May 16, 2024

smorovic commented May 16, 2024

smorovic commented May 17, 2024

smorovic commented May 17, 2024

cmsbuild commented May 17, 2024

mmusich commented May 17, 2024

smorovic commented May 17, 2024

smorovic commented May 17, 2024

cmsbuild commented May 17, 2024

smorovic commented May 17, 2024

Martin-Grunewald commented May 21, 2024

tjavaid commented May 23, 2024

cmsbuild commented May 23, 2024

rappoccio commented May 29, 2024

(DAQ) remove dummy MicroStateService #44991

(DAQ) remove dummy MicroStateService #44991

Conversation

smorovic commented May 16, 2024

PR description:

PR validation:

cmsbuild commented May 16, 2024 • edited Loading

cmsbuild commented May 16, 2024

cmsbuild commented May 16, 2024

cmsbuild commented May 16, 2024

cmsbuild commented May 16, 2024

smorovic commented May 16, 2024

smorovic commented May 16, 2024

smorovic commented May 17, 2024

smorovic commented May 17, 2024

cmsbuild commented May 17, 2024

mmusich commented May 17, 2024

smorovic commented May 17, 2024

smorovic commented May 17, 2024

cmsbuild commented May 17, 2024

Comparison Summary

smorovic commented May 17, 2024

Martin-Grunewald commented May 21, 2024

tjavaid commented May 23, 2024

cmsbuild commented May 23, 2024

rappoccio commented May 29, 2024

cmsbuild commented May 16, 2024 •

edited

Loading