-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DAQ) jsoncpp moved to a namespace (14_1_X) #44989
Conversation
…ewer version of the library included by tensorflow several unused files removed
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40267
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40268
|
A new Pull Request was created by @smorovic for master. It involves the following packages:
@cmsbuild, @Martin-Grunewald, @smorovic, @emeschi, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c75752/39415/summary.html Comparison SummarySummary:
|
+daq |
type bug-fix |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Moved to jsoncollector namespace to avoid conflict with tensorflow import of this lib (newer version).
PR validation:
Tested in DAQ test system and produces valid json files.