Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DAQ) jsoncpp moved to a namespace (14_1_X) #44989

Merged
merged 2 commits into from
May 20, 2024

Conversation

smorovic
Copy link
Contributor

PR description:

Moved to jsoncollector namespace to avoid conflict with tensorflow import of this lib (newer version).

PR validation:

Tested in DAQ test system and produces valid json files.

…ewer version of the library included by tensorflow

several unused files removed
@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40267

  • This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44989/40268

  • This PR adds an extra 68KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic for master.

It involves the following packages:

  • EventFilter/Utilities (daq)
  • HLTrigger/JSONMonitoring (hlt)

@cmsbuild, @Martin-Grunewald, @smorovic, @emeschi, @mmusich can you please review it and eventually sign? Thanks.
@fwyzard, @missirol, @silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c75752/39415/summary.html
COMMIT: 0d93dfb
CMSSW: CMSSW_14_1_X_2024-05-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44989/39415/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smorovic
Copy link
Contributor Author

+daq

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

+hlt

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c52556 into cms-sw:master May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants