Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DAQ) jsoncpp moved to a namespace (14_0_X backport) #44990

Merged
merged 2 commits into from
May 22, 2024

Conversation

smorovic
Copy link
Contributor

PR description:

Moved to jsoncollector namespace to avoid conflict with tensorflow import of this lib (newer version).

PR validation:

Tested in DAQ test system and produces valid json files.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44989
See also:
#44975

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2024

A new Pull Request was created by @smorovic for CMSSW_14_0_X.

It involves the following packages:

  • EventFilter/Utilities (daq)
  • HLTrigger/JSONMonitoring (hlt)

@mmusich, @smorovic, @Martin-Grunewald, @emeschi, @cmsbuild can you please review it and eventually sign? Thanks.
@fwyzard, @silviodonato, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2024

cms-bot internal usage

@smorovic
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/summary.html
COMMIT: 6da420f
CMSSW: CMSSW_14_0_X_2024-05-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44990/39416/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/git-merge-result

Comparison Summary

Summary:

@smorovic
Copy link
Contributor Author

+daq

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

+hlt

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented May 17, 2024

backport of #44989

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 86683d0 into cms-sw:CMSSW_14_0_X May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants