-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DAQ) jsoncpp moved to a namespace (14_0_X backport) #44990
Conversation
…ewer version of the library included by tensorflow several unused files removed
A new Pull Request was created by @smorovic for CMSSW_14_0_X. It involves the following packages:
@mmusich, @smorovic, @Martin-Grunewald, @emeschi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab658b/39416/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+daq |
+hlt
|
type bug-fix |
backport of #44989 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Moved to jsoncollector namespace to avoid conflict with tensorflow import of this lib (newer version).
PR validation:
Tested in DAQ test system and produces valid json files.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44989
See also:
#44975