[14.0.X] fixup eta lookup in absEtaLowEdges_ in miscellaneous RecoEgamma/EgammaHLTProducers plugins

[mmusich]

backport of #44764

PR description:

Implements what's discussed in #44759 (comment) and #44759 (comment). Avoids bound check failures when having input candidate with eta() exactly equal to 0.

PR validation:

Run the following script:

#!/bin/bash -ex

# CMSSW_14_0_5_patch1

hltGetConfiguration run:379530 \
  --globaltag 140X_dataRun3_HLT_v3 \
  --data \
  --no-prescale \
  --no-output \
  --max-events -1 \
  --input /store/group/tsg/FOG/debug/2024-04-17_run379530/run379530_ls0556.root  > hlt.py
  
cat <<@EOF >> hlt.py
process.options.wantSummary = True

process.options.numberOfThreads = 1
process.options.numberOfStreams = 0
@EOF

cmsRun hlt.py &> hlt.log

in this branch and verified that there are no failures.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44764 to the 2024 data-taking release.

[mmusich]

type egamma, bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

• RecoEgamma/EgammaHLTProducers (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@ReyerBand, @afiqaize, @valsdav, @argiro, @Prasant1993, @sobhatta, @silviodonato, @wang0jin, @a-kapoor, @ram1123, @thomreis, @lgray, @varuns23, @rchatter, @HuguesBrun, @jainshilpi, @sameasy, @Fedespring, @Sam-Harper, @cericeci, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

• Backported from fixup eta lookup in absEtaLowEdges_ in miscellaneous RecoEgamma/EgammaHLTProducers plugins #44764

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eea3ea/38918/summary.html
COMMIT: fd3ca13
CMSSW: CMSSW_14_0_X_2024-04-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44768/38918/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 90 lines to the logs
• Reco comparison results: 37 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3318804
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3318781
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• verbatim backport of fixup eta lookup in absEtaLowEdges_ in miscellaneous RecoEgamma/EgammaHLTProducers plugins #44764 for 2024 data-taking purposes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[VinInn]

most probably
int iEA = std::lower_bound(absEtaLowEdges_.begin(),absEtaLowEdges_.end(),scEta)
would do it better.
(why we need always to re-invent the way to find a bin in a Histogram?)

[mmusich]

I considered that, this is the minimal fix.

[antoniovilela]

+1