Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Allow Runtime Number of Hits for Alpaka Pixel Reconstruction #44774

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

AdrianoDee
Copy link
Contributor

Plain backport of #44773 to 14_0_X.

solves #44769

Tested on top of CMSSW_14_0_5_patch1.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2024

A new Pull Request was created by @AdrianoDee for CMSSW_14_0_X.

It involves the following packages:

  • Geometry/CommonTopologies (geometry)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)

@makortel, @jfernan2, @Dr15Jones, @civanch, @bsunanda, @cmsbuild, @mandrenguyen, @mdhildreth can you please review it and eventually sign? Thanks.
@JanFSchulte, @tvami, @rovere, @gpetruc, @ferencek, @GiacomoSguazzoni, @bsunanda, @felicepantaleo, @mtosi, @VinInn, @fabiocos, @dgulhan, @mmusich, @missirol, @VourMa, @dkotlins, @tsusa, @threus, @mroguljic this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Apr 18, 2024

tagging @malbouis (ORM)

@AdrianoDee
Copy link
Contributor Author

enable gpu

@AdrianoDee
Copy link
Contributor Author

backport of #44773

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • enable = gpu
  • workflows = 12434.402,12434.403,12434.404
  • workflows_gpu = 12434.402,12434.403,12434.404
  • workflow_opts = -w upgrade
  • workflow_opts_gpu = -w upgrade

- update for HitToTuple map in CA
@cmsbuild
Copy link
Contributor

Pull request #44774 was updated. @bsunanda, @jfernan2, @civanch, @makortel, @Dr15Jones, @cmsbuild, @mdhildreth, @mandrenguyen can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

urgent

@AdrianoDee
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44774/40007

  • This PR adds an extra 40KB to repository

@AdrianoDee
Copy link
Contributor Author

please test

@AdrianoDee
Copy link
Contributor Author

assign heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295fff/38936/summary.html
COMMIT: 72591c3
CMSSW: CMSSW_14_0_X_2024-04-18-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44774/38936/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 5
  • DQMHistoTests: Total histograms compared: 71813
  • DQMHistoTests: Total failures: 2964
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 68849
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
  • Checked 19 log files, 22 edm output root files, 5 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

The master PR is merged. If there is time before building the patch release, check the master IB.
The patch release should add only this PR (#44774) and #44768, as requested by ORM.

@smuzaffar
Copy link
Contributor

smuzaffar commented Apr 18, 2024

lets get this merged. I will also include it on top of CMSSW_14_0_5_patchX branch ( which is based on CMSSW_14_0_5_patch1 and will only only #44774 and #44768) . in few minutes next IB for 14.0.x and 14.1.X will be build and if every thing goes fine there then I will start the 14.0.5.patch2 build

@smuzaffar smuzaffar merged commit f048ad6 into cms-sw:CMSSW_14_0_X Apr 18, 2024
15 checks passed
smuzaffar added a commit that referenced this pull request Apr 18, 2024
[14_0_X] Allow Runtime Number of Hits for Alpaka Pixel Reconstruction
@antoniovilela
Copy link
Contributor

antoniovilela commented Apr 18, 2024

lets get this merged. I will also include it on top of CMSSW_14_0_5_patchX branch ( which is based on CMSSW_14_0_5_patch1 and will only only #44774 and #44768) . in few minutes next IB for 14.0.x and 14.1.X will be build and if every thing goes fine there then I will start the 14.0.5.patch2 build

Ok, perfect.

@fwyzard
Copy link
Contributor

fwyzard commented Apr 19, 2024

@antoniovilela thank you for being proactive on this.

As far as I know we have not yet reviewed the changes and the overall impact on the HLT.

@mandrenguyen
Copy link
Contributor

+1

@fwyzard
Copy link
Contributor

fwyzard commented Apr 21, 2024

+heterogeneous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants