Merge pull request #44768 from mmusich/mm_dev_fix_RecoEgamma_EgammaHL…

…TProducers_14_0_X [14.0.X] fixup eta lookup in `absEtaLowEdges_` in miscellaneous `RecoEgamma/EgammaHLTProducers` plugins
cms-sw · Apr 18, 2024 · 8134154 · 8134154
1 parent abea8d7
commit 8134154
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTBcHcalIsolationProducersRegional.cc b/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTBcHcalIsolationProducersRegional.cc
@@ -162,14 +162,13 @@ void EgammaHLTBcHcalIsolationProducersRegional::produce(edm::StreamID,
       int iEA = -1;
       auto scEta = std::abs(recoEcalCandRef->superCluster()->eta());
       for (int bIt = absEtaLowEdges_.size() - 1; bIt > -1; bIt--) {
-        if (scEta > absEtaLowEdges_.at(bIt)) {
+        if (scEta >= absEtaLowEdges_[bIt]) {
           iEA = bIt;
           break;
         }
       }
-      isol = isol - rho * effectiveAreas_.at(iEA);
+      isol = isol - rho * effectiveAreas_[iEA];
     }
-
     isoMap.insert(recoEcalCandRef, isol);
   }
 

diff --git a/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHcalVarProducerFromRecHit.cc b/RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHcalVarProducerFromRecHit.cc
@@ -229,12 +229,12 @@ void EgammaHLTHcalVarProducerFromRecHit::produce(edm::StreamID,
       int iEA = -1;
       auto scEta = std::abs(recoEcalCandRef->superCluster()->eta());
       for (int bIt = absEtaLowEdges_.size() - 1; bIt > -1; bIt--) {
-        if (scEta > absEtaLowEdges_.at(bIt)) {
+        if (scEta >= absEtaLowEdges_[bIt]) {
           iEA = bIt;
           break;
         }
       }
-      isol = isol - rho * effectiveAreas_.at(iEA);
+      isol = isol - rho * effectiveAreas_[iEA];
     }
 
     isoMap.insert(recoEcalCandRef, isol);

diff --git a/RecoEgamma/EgammaHLTProducers/plugins/HLTEcalPFClusterIsolationProducer.cc b/RecoEgamma/EgammaHLTProducers/plugins/HLTEcalPFClusterIsolationProducer.cc
@@ -174,13 +174,12 @@ void HLTEcalPFClusterIsolationProducer<T1>::produce(edm::Event& iEvent, const ed
       int iEA = -1;
       auto cEta = std::abs(candRef->eta());
       for (int bIt = absEtaLowEdges_.size() - 1; bIt > -1; bIt--) {
-        if (cEta > absEtaLowEdges_.at(bIt)) {
+        if (cEta >= absEtaLowEdges_[bIt]) {
           iEA = bIt;
           break;
         }
       }
-
-      sum = sum - rho * effectiveAreas_.at(iEA);
+      sum = sum - rho * effectiveAreas_[iEA];
     }
 
     recoCandMap.insert(candRef, sum);

diff --git a/RecoEgamma/EgammaHLTProducers/plugins/HLTHcalPFClusterIsolationProducer.cc b/RecoEgamma/EgammaHLTProducers/plugins/HLTHcalPFClusterIsolationProducer.cc
@@ -200,13 +200,12 @@ void HLTHcalPFClusterIsolationProducer<T1>::produce(edm::StreamID sid,
       int iEA = -1;
       auto cEta = std::abs(candRef->eta());
       for (int bIt = absEtaLowEdges_.size() - 1; bIt > -1; bIt--) {
-        if (cEta > absEtaLowEdges_.at(bIt)) {
+        if (cEta >= absEtaLowEdges_[bIt]) {
           iEA = bIt;
           break;
         }
       }
-
-      sum = sum - rho * effectiveAreas_.at(iEA);
+      sum = sum - rho * effectiveAreas_[iEA];
     }
 
     recoCandMap.insert(candRef, sum);