Add HGCAL Hit calibration to Phase2 HLT.

[rovere]

PR description:

Add the HGCAL hit calibration validation module to Phase 2 HLT validation. This will be able to catch, in future, issues similar to those reported in #44552

PR validation:

Tested on a Phase2 workflow: plots are created and properly filled.

[cmsbuild]

cms-bot internal usage

[rovere]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44558/39697

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @rovere for master.

It involves the following packages:

• HLTriggerOffline/Common (dqm)
• Validation/HGCalValidation (dqm)

@rvenditti, @nothingface0, @syuvivida, @antoniovagnerini, @tjavaid can you please review it and eventually sign? Thanks.
@missirol, @sethzenz, @vandreev11, @mtosi, @lgray, @apsallid, @bsunanda, @youyingli, @hatakeyamak, @lecriste, @cseez, @pfs this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c2f23/38459/summary.html
COMMIT: 102e088
CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44558/38459/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 63 lines from the logs
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297857
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297834
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 382.974 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 3.979 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_scint_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_100_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_200_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_300_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.976 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_scint_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_100_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_200_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_300_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.972 KiB HGCalHitCalibrationHLT/hgcal_EoP_CPene_scint_calib_fraction
• DQMHistoSizes: changed ( 23234.0,... ): 3.970 KiB HGCalHitCalibrationHLT/hgcal_EoP_CPene_100_calib_fraction
• DQMHistoSizes: changed ( 23234.0 ): ...
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[rovere]

ping dqm

[rovere]

@srimanob we would need this PR merged and an equivalent backport to 14_0 to be sure HGCAL is correctly calibrated w/ the geometry to be used for 2024 Spring Phase2 production.

[mmusich]

@cms-sw/dqm-l2 please take a look.

[srimanob]

@srimanob we would need this PR merged and an equivalent backport to 14_0 to be sure HGCAL is correctly calibrated w/ the geometry to be used for 2024 Spring Phase2 production.

Thanks @rovere
So, if I understand correctly, this PR is not for production mode. But it is good for relvals we are going to produce in 14_0. Right?

[rovere]

Ciao @srimanob
this PR is meant to monitor the HGCAL calibration in the Phase2 HLT Menu constantly. It is useful while testing PR and doing release validation with RelVals.

[tjavaid]

+1

• @rovere , do you want to make its backport PR for 14_0_X ?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1