[14.0.X] HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL

[AuroraPerego]

This is a backport of #44552

This PR fixes a bug where the value of fCperElectron was accidentally set to 0. This caused noise hits to seed the creation of layerclusters.
In this PR all the constants have been moved to a common file, so it's easier to maintain, and have been updated to Calorimeter Geometry v16.

Validated running workflow 24896.0 and using plots from #44558 to check the correctness of the result

FYI @felicepantaleo @rovere

[cmsbuild]

A new Pull Request was created by @AuroraPerego for CMSSW_14_0_X.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @silviodonato, @rovere, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44552

[cmsbuild]

cms-bot internal usage

[mmusich]

backport of #44552

[mmusich]

type hgcal, bug-fix

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e837db/38560/summary.html
COMMIT: 654bda5
CMSSW: CMSSW_14_0_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44596/38560/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 21 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 255 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346148
• DQMHistoTests: Total failures: 1372
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344754
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: found differences in 3 / 47 workflows

[mmusich]

This PR is not a "verbatim" backport of #44552.

If I compare the diffs I see for this PR:

 .../modules/HGCalRecHitL1Seeded_cfi.py        | 23 ++----
 .../HLT_75e33/modules/HGCalRecHit_cfi.py      | 26 ++----
 .../modules/HGCalUncalibRecHitL1Seeded_cfi.py |  5 +-
 .../modules/HGCalUncalibRecHit_cfi.py         |  6 +-
 .../hgcalLayerClustersEEL1Seeded_cfi.py       | 77 ++++++------------
 .../modules/hgcalLayerClustersEE_cfi.py       | 80 +++++++------------
 .../hgcalLayerClustersHSciL1Seeded_cfi.py     | 79 +++++++-----------
 .../modules/hgcalLayerClustersHSci_cfi.py     | 80 +++++++------------
 .../hgcalLayerClustersHSiL1Seeded_cfi.py      | 79 +++++++-----------
 .../modules/hgcalLayerClustersHSi_cfi.py      | 79 ++++++------------
 .../psets/hgcal_reco_constants_cfi.py         | 43 ++++++++++
  11 files changed, 221 insertions(+), 356 deletions(-)

whereas for #44552:

 .../modules/HGCalRecHitL1Seeded_cfi.py        | 23 ++------
 .../HLT_75e33/modules/HGCalRecHit_cfi.py      | 26 ++-------
 .../modules/HGCalUncalibRecHitL1Seeded_cfi.py |  5 +-
 .../modules/HGCalUncalibRecHit_cfi.py         |  6 +-
 .../hgcalLayerClustersEEL1Seeded_cfi.py       | 55 ++++++-------------
 .../modules/hgcalLayerClustersEE_cfi.py       | 54 ++++++------------
 .../hgcalLayerClustersHSciL1Seeded_cfi.py     | 55 ++++++-------------
 .../modules/hgcalLayerClustersHSci_cfi.py     | 54 ++++++------------
 .../hgcalLayerClustersHSiL1Seeded_cfi.py      | 55 ++++++-------------
 .../modules/hgcalLayerClustersHSi_cfi.py      | 54 ++++++------------
 .../psets/hgcal_reco_constants_cfi.py         | 42 ++++++++++++++
 11 files changed, 159 insertions(+), 270 deletions(-)

also the Trigger results comparisons do not agree:

• This PR: TriggerResults: found differences in 3 / 47 workflows
• HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44552 TriggerResults: found differences in 2 / 46 workflows

[rovere]

@mmusich thanks for checking.
The diffs are different because 14_1 has #44025 merged (that also touched the same files touched by this PR and by #44552), while 14_0 does not have it. So, the baseline to compute the diff is different.
I checked the content of the diffs and everything seems to be correct.

The changes in the trigger results are more difficult to explain. I can imagine having some regression since HGCAL was uncalibrated before. Possibly, the differences with respect to #44552 could be explained if we fold in also #44025 and #44523...?

[mmusich]

+hlt

• see [14.0.X] HLT phase-2: fix HGCAL Layercluster and create common constants configuration for HGCAL #44596 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1