[CPP20][L1,UPGRADE] Replace some enums with constexpr ints

[iarspider]

PR description:

Replace some enums with constexpr ints to avoid deprecated enum arithmetics. Replaces #44489 following @makortel's suggestion.

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44534/39665

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/CSCDigi (simulation)
• DataFormats/L1CSCTrackFinder (l1)
• DataFormats/L1TrackTrigger (upgrade, l1)
• L1Trigger/GlobalCaloTrigger (l1)
• L1Trigger/HardwareValidation (l1)
• L1Trigger/L1ExtraFromDigis (l1)
• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
• L1Trigger/RPCTrigger (l1)
• L1Trigger/TrackTrigger (upgrade, l1)
• L1Trigger/VertexFinder (l1)

@epalencia, @subirsarkar, @mdhildreth, @srimanob, @aloeliger, @civanch can you please review it and eventually sign? Thanks.
@missirol, @rovere, @erikbutz, @JanFSchulte, @eyigitba, @giovanni-mocellin, @skinnari, @ptcox, @sviret, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c6833/38390/summary.html
COMMIT: 2060718
CMSSW: CMSSW_14_1_CPP20_X_2024-03-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44534/38390/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Use default op= in LASModuleProfile #44463
• @bsunanda Phase2-gex177 Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8 #44493
• @makortel Initialize statsGuard_ on LogErrorEventFilter #44447
• @stahlleiton Run3 era for 2024 pp reference and UPC reco #44316
• @bsunanda Phase2-hgx354B First attempt to prepare components of XML file for the scintillator components in the mixed layers of HGCal #44478
• @vlimant fix standard and upgrade validation workflows #44464
• @rdelliga MTD Validation: Characterization of PU contribution in vertices #44405
• @Dr15Jones Modified message from MaxMemoryPreload #44502
• @RSalvatico Modify trigger filterBits for electrons and photons in custom EGM Nano #44496
• @Dr15Jones Moved modules.py out of edmWriteConfig #44396

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c6833/38390/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c6833/38390/git-merge-result

Build

I found compilation error when building:

>> Compiling  src/DataFormats/L1TrackTrigger/src/TTCluster.cc
>> Compiling  src/DataFormats/L1TrackTrigger/src/TTDTC.cc
>> Compiling  src/DataFormats/L1TrackTrigger/src/TTTrack.cc
>> Compiling  src/DataFormats/L1TrackTrigger/src/TTTrack_TrackWord.cc
In file included from src/DataFormats/L1TrackTrigger/src/TTTrack_TrackWord.cc:13:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CPP20_X_2024-03-22-1100/src/DataFormats/L1TrackTrigger/interface/TTTrack_TrackWord.h:55:54: error: stray ',' at end of member declaration
   55 |                                         kMVAOtherSize,  // Width of the track word in bits
      |                                                      ^
      |                                                      -
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_CPP20_X_2024-03-22-1100/src/DataFormats/L1TrackTrigger/interface/TTTrack_TrackWord.h:132:39: error: 'kTrackWordSize' is not a member of 'TTTrack_TrackWord::TrackBitWidths'
  132 |   typedef std::bitset tkword_bs_t;  // Entire track word;


[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44534/39676

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #44534 was updated. @epalencia, @subirsarkar, @aloeliger, @civanch, @mdhildreth, @srimanob can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44534/39682

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #44534 was updated. @epalencia, @aloeliger, @mdhildreth, @civanch, @cmsbuild, @subirsarkar, @srimanob can you please check and sign again.

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c6833/38417/summary.html
COMMIT: 57f96fb
CMSSW: CMSSW_14_1_CPP20_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44534/38417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2438 lines to the logs
• Reco comparison results: 129 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 511
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297006
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• Technical tweaks

[srimanob]

+Upgrade

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1