-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx354B First attempt to prepare components of XML file for the scintillator components in the mixed layers of HGCal #44478
Conversation
…components in the mixed layers of HGCal
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44478/39561
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44478/39562
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@makortel, @civanch, @Dr15Jones, @subirsarkar, @cmsbuild, @mdhildreth, @srimanob, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c09645/38272/summary.html Comparison SummarySummary:
|
+geometry |
@srimanob Please approve this PR |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@antoniovilela, @rappoccio Please merge this PR. Need the merged IB for future work |
+1 |
PR description:
First attempt to prepare components of XML file for the scintillator components in the mixed layers of HGCal
PR validation:
Extraction of the components works and now to be inserted into new XML files for the V19 version of HGCal geometry
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special