-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD Validation: Characterization of PU contribution in vertices #44405
Conversation
…ogPrint for debugging, mePUTrackRecLVWnt_->fill() moved
…lots for Primary4DVertexValidation.cc, removed EDM_ML_DEBUG from MtdTracksValidation.cc
…s modified, some comments rewritten, member data for min threshold in log histograms added
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44405/39478
|
A new Pull Request was created by @rdelliga for master. It involves the following packages:
@antoniovagnerini, @tjavaid, @syuvivida, @nothingface0, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71fe79/38139/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 any comment? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Plots added to Primary4DVertexValidation.cc to monitor the impact of Pileup in order to compare different vertex reconstruction algorithms. For details see the presentation at https://indico.cern.ch/event/1390639/contributions/5846174/attachments/2816069/4924070/MTD_DPG_March_DelliGatti.pdf
Furthermore, EDM_ML_DEBUG from MtdTracksValidation.cc, integrated with pull request #43741, was removed.
PR validation:
Code compilation and production of plots.