Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD Validation: Characterization of PU contribution in vertices #44405

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

rdelliga
Copy link
Contributor

PR description:

Plots added to Primary4DVertexValidation.cc to monitor the impact of Pileup in order to compare different vertex reconstruction algorithms. For details see the presentation at https://indico.cern.ch/event/1390639/contributions/5846174/attachments/2816069/4924070/MTD_DPG_March_DelliGatti.pdf
Furthermore, EDM_ML_DEBUG from MtdTracksValidation.cc, integrated with pull request #43741, was removed.

PR validation:

Code compilation and production of plots.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

cms-bot internal usage

@rdelliga rdelliga changed the title Pu contribution MTD Validation: Characterization of PU contribution in vertices Mar 14, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44405/39478

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rdelliga for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @tjavaid, @syuvivida, @nothingface0, @cmsbuild, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71fe79/38139/summary.html
COMMIT: 42b0c6d
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44405/38139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 23 lines to the logs
  • Reco comparison results: 62 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 1358
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3296002
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 30.714 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 5.119 KiB MTD/Vertices
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fabiocos
Copy link
Contributor

@cms-sw/dqm-l2 any comment?

@tjavaid
Copy link

tjavaid commented Mar 21, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants