Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom filterbits for EGM Nano [14_0_X] #44524

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add custom filterbits for EGM Nano [14_0_X] #44524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa481dd
Add custom filterbits for EGM Nano
RSalvatico Mar 23, 2024
1133cef
add wildcard for mu-ele path
RSalvatico Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions PhysicsTools/NanoAOD/python/egamma_custom_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,88 @@
from PhysicsTools.NanoAOD.NanoAODEDMEventContent_cff import *
from PhysicsTools.NanoAOD.nanoDQM_cfi import nanoDQM
from PhysicsTools.NanoAOD.nanoDQM_cff import _Photon_extra_plots, _Electron_extra_plots
from PhysicsTools.NanoAOD.triggerObjects_cff import triggerObjectTable, mksel

customElectronFilterBits = cms.PSet(
doc = cms.string("PixelMatched e/gamma"), # this may also select photons!
id = cms.int32(11),
sel = cms.string("type(92) && pt > 7 && (coll('hltEgammaCandidates') || coll('hltEgammaCandidatesUnseeded')) && (filter('*PixelMatchFilter') || filter('*PixelMatchUnseededFilter'))"),
l1seed = cms.string("type(-98)"), l1deltaR = cms.double(0.3),
skipObjectsNotPassingQualityBits = cms.bool(True),
qualityBits = cms.VPSet(
#HLT_Ele30_WPTight_Gsf
mksel("filter('hltEGL1SingleEGOrFilter')","1e WPTight L1T match"),
mksel("filter('hltEG30L1SingleEGOrEtFilter')","1e WPTight Et"),
mksel("filter('hltEle30WPTightClusterShapeFilter')","1e WPTight SigmaIeIe"),
mksel("filter('hltEle30WPTightHEFilter')","1e WPTight HoE"),
mksel("filter('hltEle30WPTightEcalIsoFilter')","1e WPTight ECAL Iso"),
mksel("filter('hltEle30WPTightHcalIsoFilter')","1e WPTight HCAL Iso"),
mksel("filter('hltEle30WPTightPixelMatchFilter')","1e WPTight Pixel match"),
mksel("filter('hltEle30WPTightPMS2Filter')","1e WPTight S2"),
mksel("filter('hltEle30WPTightGsfOneOEMinusOneOPFilter')","1e WPTight 1/E-1/p"),
mksel("filter('hltEle30WPTightGsfMissingHitsFilter')","1e WPTight missing hits"),
mksel("filter('hltEle30WPTightGsfDetaFilter')","1e WPTight DEta"),
mksel("filter('hltEle30WPTightGsfDphiFilter')","1e WPTight DPhi"),
mksel("filter('hltEle30WPTightGsfTrackIsoFilter')","1e WPTight Track Iso"),
#HLT_Ele23_Ele12_CaloIdL_TrackIdL_IsoVL
mksel("filter('hltEGL1SingleAndDoubleEGOrPairFilter')","2e L1T match"),
mksel("filter('hltEle23Ele12CaloIdLTrackIdLIsoVLTrackIsoLeg1Filter')","2e Track Iso Leg1"),
mksel("filter('hltEle23Ele12CaloIdLTrackIdLIsoVLTrackIsoLeg2Filter')","2e Track Iso Leg2"),
#HLT_DoubleEle33_CaloIdL_MW
mksel("filter('hltEGL1SingleAndDoubleEGNonIsoOrWithEG26WithJetAndTauFilter')","2e (CaloIdL_MW) L1T match"),
mksel("filter('hltEle33CaloIdLPixelMatchFilter')","2e (CaloIdL_MW) Pixel match Leg1"),
mksel("filter('hltEle33CaloIdLMWPMS2Filter')","2e (CaloIdL_MW) S2"),
mksel("filter('hltDiEle33CaloIdLMWPMS2UnseededFilter')","2e (CaloIdL_MW unseeded) S2"),
#HLT_Photon200
mksel("filter('hltEG200HEFilter')","1e Photon200"),
#HLT_Photon50EB
mksel("filter('hltEG50EBEtFilter')","1e Photon50EB"),
#HLT_Ele16_Ele12_Ele8_CaloIdL_TrackIdL
mksel("filter('hltEle16Ele12Ele8CaloIdLTrackIdLDphiLeg3Filter')","3e Leg3"),
#HLT_Mu12_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL
mksel("filter('hltMu12TrkIsoVVLEle23CaloIdLTrackIdLIsoVLElectronlegTrackIsoFilter')","1mu-1e eLeg"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this might change to hltMuTrkIsoVVLEle23CaloIdLTrackIdLIsoVLElectronlegTrackIsoFilter as part of CMSHLT-2984. Using wildcards as in [*] is probably wiser.

[*]

cmssw/PhysicsTools/NanoAOD/python/triggerObjects_cff.py

Line 68 in 3db8147

mksel("filter('hltMu*TrkIsoVVL*Ele*CaloIdLTrackIdLIsoVL*Filter*')","1e-1mu"),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @missirol, I didn't know about this.
What we want to achieve with these new filter bits in EGM Nano is exactly to get rid of wildcards, so that in principle we have a perfect control of what we are measuring (if, e.g., we are using Nano for efficiencies) and no contamination from other paths or from similar paths with different thresholds. For this specific case and since we are talking about an electron leg that is the same for several mu-ele paths, we don't have the aforementioned problem and I am OK to add one wildcard as follows:
hltMu*TrkIsoVVLEle23CaloIdLTrackIdLIsoVLElectronlegTrackIsoFilter
to be prepared for the possible change in the naming convention in the menu. I will have to change that in cms-sw:master too, since there the new version with no wildcards was already merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks @RSalvatico.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RSalvatico It seems that we lost track of propagating this change to master. Could you please open a PR? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hqucms Yes, done in #44809.

#HLT_Ele24_eta2p1_WPTight_Gsf_PNetTauhPFJet30_*_eta2p3_CrossL1 OR HLT_Ele24_eta2p1_WPTight_Gsf_LooseDeepTauPFTauHPS30_eta2p1_CrossL1
mksel("filter('hltEle24erWPTightGsfTrackIsoFilterForTau')","1e-1tau eLeg"),
)
)

customPhotonFilterBits = cms.PSet(
id = cms.int32(22),
sel = cms.string("type(92) && pt > 15 && coll('hltEgammaCandidates')"),
l1seed = cms.string("type(-98)"), l1deltaR = cms.double(0.3),
skipObjectsNotPassingQualityBits = cms.bool(True),
qualityBits = cms.VPSet(
#HLT_Photon50EB
mksel("filter('hltEG50EBEtFilter')","Photon50EB"),
#HLT_Photon***
mksel("filter('hltEG120HEFilter')","Photon120"),
mksel("filter('hltEG150HEFilter')","Photon150"),
mksel("filter('hltEG175HEFilter')","Photon175"),
mksel("filter('hltEG200HEFilter')","Photon200"),
#HLT_ECALHT800
mksel("filter('hltHtEcal800')","ECAL HT800"),
#HLT_Photon110EB_TightID_TightIso
mksel("filter('hltEG110EBTightIDTightIsoTrackIsoFilter')","Photon110EB Tight"),
#HLT_Mu17_Photon30_IsoCaloId
mksel("filter('hltMu17Photon30IsoCaloIdPhotonlegTrackIsoFilter')","1mu-1photon"),
#HLT_Diphoton30_22_R9Id_OR_IsoCaloId_AND_HE_R9Id_Mass90/95
mksel("filter('hltEG30LR9Id85b90eHE12R9Id50b80eR9IdLastFilter')","diPhoton 30_22 R9ID"),
mksel("filter('hltEG30LIso60CaloId15b35eHE12R9Id50b80eEcalIsoLastFilter')","diPhoton 30_22 ECALIso"),
mksel("filter('hltEG22R9Id85b90eHE12R9Id50b80eR9UnseededLastFilter')","diPhoton 30_22 unseeded R9ID"),
mksel("filter('hltEG22Iso60CaloId15b35eHE12R9Id50b80eTrackIsoUnseededLastFilter')","diPhoton 30_22 unseeded TrackIso"),
)
)

def addExtraEGammaVarsCustomize(process):
#photon
process.photonTable.variables.setValue(_phoVarsExtra.parameters_())
process.triggerObjectTable.selections.Photon = customPhotonFilterBits
if process.nanoDQM:
process.nanoDQM.vplots.Photon.plots = _Photon_extra_plots
#electron
process.electronTable.variables.setValue(_eleVarsExtra.parameters_())
process.triggerObjectTable.selections.Electron = customElectronFilterBits
if process.nanoDQM:
process.nanoDQM.vplots.Electron.plots = _Electron_extra_plots

return process