Add custom filterbits for EGM Nano [14_0_X] #44524

RSalvatico · 2024-03-23T10:37:51Z

PR description:

Backport of #44496, to modify the filterBits content for the TrigObjs with id = 11 and id = 22 (electrons and photons, respectively) in the custom EGM Nano only, to better suit the current needs of the POG.

N.B. This is not anymore a verbatim copy of the original PR, since it was brought to my attention that one mu-ele cross path is likely going to change name soon, so I had to wildcard it here.

PR validation:

Same as #44496.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR: #44496. This backport is meant to add these changes to the release that will be used for the next NanoAOD production.

cmsbuild · 2024-03-23T10:38:14Z

A new Pull Request was created by @RSalvatico for CMSSW_14_0_X.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-03-23T10:38:14Z

cms-bot internal usage

RSalvatico · 2024-03-23T10:39:27Z

type egamma

RSalvatico · 2024-03-23T10:40:06Z

enable nano

RSalvatico · 2024-03-23T10:40:22Z

please test

cmsbuild · 2024-03-23T13:34:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc4526/38362/summary.html
COMMIT: aa481dd
CMSSW: CMSSW_14_0_X_2024-03-22-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44524/38362/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 58 lines to the logs
Reco comparison results: 62 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346148
DQMHistoTests: Total failures: 1355
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344771
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16402
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16402
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.548	0.000 ( +0.0% )	5.23	5.18	+1.1%	2.225	2.103
2500.001	2.698	2.698	0.000 ( +0.0% )	4.67	4.71	-1.0%	2.647	2.109
2500.002	2.638	2.638	0.000 ( +0.0% )	4.83	4.87	-0.7%	2.630	2.127
2500.01	1.318	1.318	0.000 ( +0.0% )	9.60	9.81	-2.1%	2.276	1.982
2500.011	1.740	1.740	0.000 ( +0.0% )	5.22	5.24	-0.4%	2.460	1.978
2500.012	1.581	1.581	0.000 ( +0.0% )	7.52	7.46	+0.8%	2.327	1.991
2500.1	2.192	2.192	0.000 ( +0.0% )	5.31	5.29	+0.4%	2.074	2.047
2500.2	2.308	2.308	0.000 ( +0.0% )	6.06	6.09	-0.4%	1.979	1.929
2500.21	1.181	1.181	0.000 ( +0.0% )	4.29	4.35	-1.4%	2.282	1.953
2500.211	1.545	1.545	0.000 ( +0.0% )	3.80	3.81	-0.3%	2.362	1.946
2500.3	2.058	2.058	0.000 ( +0.0% )	12.42	12.76	-2.7%	1.968	1.967
2500.301	2.630	2.631	-0.001 ( -0.0% )	9.92	10.26	-3.4%	1.952	1.955
2500.31	1.254	1.254	0.000 ( +0.0% )	19.86	20.29	-2.1%	2.355	2.352
2500.311	1.640	1.640	0.000 ( +0.0% )	13.76	13.78	-0.1%	2.439	2.449
2500.312	7.159	7.159	0.000 ( +0.0% )	1.44	1.45	-0.4%	1.692	1.695
2500.313	1.564	1.564	0.000 ( +0.0% )	7.00	6.69	+4.7%	1.054	1.042
2500.314	1.163	1.163	0.000 ( +0.0% )	14.29	14.26	+0.2%	2.080	2.058
2500.315	1.756	1.758	-0.003 ( -0.1% )	14.21	14.12	+0.6%	2.331	1.930
2500.4	2.058	2.058	0.000 ( +0.0% )	12.39	12.54	-1.2%	1.854	1.838
2500.401	1.824	1.824	0.000 ( +0.0% )	10.63	10.80	-1.5%	1.819	1.581
2500.402	2.630	2.631	-0.001 ( -0.0% )	9.65	10.17	-5.1%	1.793	1.784
2500.5	19.575	19.575	0.000 ( +0.0% )	1.27	1.33	-4.6%	1.284	1.198

missirol · 2024-03-23T18:05:36Z

PhysicsTools/NanoAOD/python/egamma_custom_cff.py

+        #HLT_Ele16_Ele12_Ele8_CaloIdL_TrackIdL
+        mksel("filter('hltEle16Ele12Ele8CaloIdLTrackIdLDphiLeg3Filter')","3e Leg3"),
+        #HLT_Mu12_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL
+        mksel("filter('hltMu12TrkIsoVVLEle23CaloIdLTrackIdLIsoVLElectronlegTrackIsoFilter')","1mu-1e eLeg"),


Note: this might change to hltMuTrkIsoVVLEle23CaloIdLTrackIdLIsoVLElectronlegTrackIsoFilter as part of CMSHLT-2984. Using wildcards as in [*] is probably wiser.

[*]

cmssw/PhysicsTools/NanoAOD/python/triggerObjects_cff.py

Line 68 in 3db8147

mksel("filter('hltMu*TrkIsoVVL*Ele*CaloIdLTrackIdLIsoVL*Filter*')","1e-1mu"),

Thanks @missirol, I didn't know about this.
What we want to achieve with these new filter bits in EGM Nano is exactly to get rid of wildcards, so that in principle we have a perfect control of what we are measuring (if, e.g., we are using Nano for efficiencies) and no contamination from other paths or from similar paths with different thresholds. For this specific case and since we are talking about an electron leg that is the same for several mu-ele paths, we don't have the aforementioned problem and I am OK to add one wildcard as follows:
hltMu*TrkIsoVVLEle23CaloIdLTrackIdLIsoVLElectronlegTrackIsoFilter
to be prepared for the possible change in the naming convention in the menu. I will have to change that in cms-sw:master too, since there the new version with no wildcards was already merged.

Okay, thanks @RSalvatico.

@RSalvatico It seems that we lost track of propagating this change to master. Could you please open a PR? Thanks!

@hqucms Yes, done in #44809.

cmsbuild · 2024-03-25T16:37:41Z

Pull request #44524 was updated. @vlimant, @cmsbuild, @hqucms can you please check and sign again.

RSalvatico · 2024-03-25T16:39:01Z

please test

cmsbuild · 2024-03-26T00:16:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc4526/38400/summary.html
COMMIT: 1133cef
CMSSW: CMSSW_14_0_X_2024-03-25-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44524/38400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 72 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 37 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3243082
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3243060
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 163 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16402
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16402
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.548	0.000 ( +0.0% )	5.11	5.19	-1.7%	2.160	1.812
2500.001	2.698	2.698	0.000 ( +0.0% )	4.61	4.62	-0.2%	2.578	2.198
2500.002	2.638	2.638	0.000 ( +0.0% )	4.79	4.82	-0.7%	2.583	2.159
2500.01	1.318	1.318	0.000 ( +0.0% )	9.22	9.49	-2.8%	2.268	1.921
2500.011	1.740	1.740	0.000 ( +0.0% )	5.06	5.13	-1.4%	2.417	2.063
2500.012	1.581	1.581	0.000 ( +0.0% )	7.12	7.29	-2.4%	2.423	1.984
2500.1	2.192	2.192	0.000 ( +0.0% )	5.27	5.32	-0.9%	1.998	1.923
2500.2	2.308	2.308	0.000 ( +0.0% )	5.98	6.07	-1.5%	1.879	1.809
2500.21	1.181	1.181	0.000 ( +0.0% )	4.22	4.29	-1.6%	2.322	1.787
2500.211	1.545	1.545	0.000 ( +0.0% )	3.49	3.58	-2.6%	2.199	1.824
2500.3	2.058	2.058	0.000 ( +0.0% )	12.52	12.14	+3.1%	1.900	1.786
2500.301	2.630	2.631	-0.001 ( -0.0% )	8.79	9.65	-8.8%	1.811	1.832
2500.31	1.254	1.254	0.000 ( +0.0% )	19.10	19.74	-3.2%	2.228	1.840
2500.311	1.640	1.640	0.000 ( +0.0% )	10.04	12.00	-16.4%	2.252	1.872
2500.312	7.159	7.159	0.000 ( +0.0% )	1.12	1.25	-9.8%	1.693	1.669
2500.313	1.564	1.564	0.000 ( +0.0% )	3.91	5.85	-33.1%	1.054	1.051
2500.314	1.163	1.163	0.000 ( +0.0% )	10.82	12.32	-12.2%	2.100	1.683
2500.315	1.756	1.758	-0.002 ( -0.1% )	11.49	13.16	-12.7%	2.200	2.209
2500.4	2.058	2.058	0.000 ( +0.0% )	12.07	12.24	-1.4%	1.858	1.858
2500.401	1.824	1.824	0.000 ( +0.0% )	8.54	9.90	-13.7%	1.680	1.725
2500.402	2.630	2.631	-0.001 ( -0.0% )	8.08	9.54	-15.3%	1.849	1.758
2500.5	19.575	19.575	0.000 ( +0.0% )	0.45	0.67	-33.1%	1.114	1.123

vlimant · 2024-03-27T17:35:23Z

+1

cmsbuild · 2024-03-27T17:35:46Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-03-28T13:19:44Z

Why are we back porting a new feature to the stable 14_0 branch?

RSalvatico · 2024-03-28T13:25:31Z

Why are we back porting a new feature to the stable 14_0 branch?

My understanding is that 140X will be used to make NanoAOD v14 and if we request a custom EGM-Nano production in the near future we would like to be consistent with that. Plus, isn't 140something used in the data taking right now? If I am not wrong, the plan is that at some point these custom flavors of Nano will be produced at T0, which I think implies that the desired configuration has to be inside the release that is run at T0.

vlimant · 2024-03-30T09:18:00Z

@cms-sw/orp-l2 ; as this is not affecting the mainstream NANO, but only the EGM customisation of it (that might be deployed at T0 at some point), can you please merge this, as it’s not really controversial.

antoniovilela · 2024-03-31T22:34:40Z

@cms-sw/orp-l2 ; as this is not affecting the mainstream NANO, but only the EGM customisation of it (that might be deployed at T0 at some point), can you please merge this, as it’s not really controversial.

@vlimant @cms-sw/ppd-l2
We have this and a few more for the Nano production with 14_0_X. Please highlight all that are needed in the ORP meeting next Tue, and we can target them for a following 14_0_X build (after 14_0_4).
Thanks.

rappoccio · 2024-04-01T17:33:38Z

hold

To be discussed at ORP and needs explicit signoff from PPD.

cmsbuild · 2024-04-01T17:33:59Z

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

malbouis · 2024-04-01T20:48:15Z

Hi @rappoccio and @antoniovilela , thanks for tagging us here. In principle the custom nanos are supposed to be produced at Tier0 in a separate file from the regular Nano. Having this in mind, I think it is fine to proceed with this PR.
We had also agreed with xpog that the changes for NanoAODv14 could go in until April 10th. In this sense, it is also still in accordance to what we have agreed.
As a matter of fact, we are expecting a few PRs to still come in for Nano, like the unified tagger for BTV/JME/TAU (I haven't checked if it was already submitted though).
Thanks!

antoniovilela · 2024-04-02T14:20:23Z

Hi @rappoccio and @antoniovilela , thanks for tagging us here. In principle the custom nanos are supposed to be produced at Tier0 in a separate file from the regular Nano. Having this in mind, I think it is fine to proceed with this PR. We had also agreed with xpog that the changes for NanoAODv14 could go in until April 10th. In this sense, it is also still in accordance to what we have agreed. As a matter of fact, we are expecting a few PRs to still come in for Nano, like the unified tagger for BTV/JME/TAU (I haven't checked if it was already submitted though). Thanks!

@cms-sw/xpog-l2 @cms-sw/ppd-l2
Since we have a batch of PRs, for Nano at Tier-0 or Nano vXY processing, let's list all that is needed so that we try to have them consistently in a release, and plan the build accordingly. We can highlight all needed PRs in the ORP meeting today (Tue).

antoniovilela · 2024-04-02T22:06:43Z

unhold

antoniovilela · 2024-04-02T22:06:48Z

+1

cmsbuild · 2024-04-02T22:07:05Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

Add custom filterbits for EGM Nano

aa481dd

cmsbuild added this to the CMSSW_14_0_X milestone Mar 23, 2024

cmsbuild added pending-signatures tests-pending orp-pending xpog-pending labels Mar 23, 2024

cmsbuild added the egamma label Mar 23, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 23, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2024

missirol reviewed Mar 23, 2024

View reviewed changes

add wildcard for mu-ele path

1133cef

cmsbuild added tests-pending and removed tests-approved labels Mar 25, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 25, 2024

RSalvatico changed the title ~~Add custom filterbits for EGM Nano~~ Add custom filterbits for EGM Nano [14_0_X] Mar 25, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Mar 27, 2024

cmsbuild added pending-signatures hold and removed fully-signed labels Apr 1, 2024

cmsbuild added fully-signed orp-approved and removed pending-signatures orp-pending hold labels Apr 2, 2024

cmsbuild merged commit 3b17fcb into cms-sw:CMSSW_14_0_X Apr 2, 2024
12 checks passed

This was referenced Apr 23, 2024

Correct one filterBit name in EGMNano and add one more #44809

Merged

Add filterBit to EGMNano [14_0_X] #44812

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom filterbits for EGM Nano [14_0_X] #44524

Add custom filterbits for EGM Nano [14_0_X] #44524

RSalvatico commented Mar 23, 2024 •

edited

Loading

cmsbuild commented Mar 23, 2024

cmsbuild commented Mar 23, 2024 •

edited

Loading

RSalvatico commented Mar 23, 2024

RSalvatico commented Mar 23, 2024

RSalvatico commented Mar 23, 2024

cmsbuild commented Mar 23, 2024

missirol Mar 23, 2024

RSalvatico Mar 25, 2024

missirol Mar 25, 2024

hqucms Apr 22, 2024

RSalvatico Apr 23, 2024

cmsbuild commented Mar 25, 2024

RSalvatico commented Mar 25, 2024

cmsbuild commented Mar 26, 2024

vlimant commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

rappoccio commented Mar 28, 2024

RSalvatico commented Mar 28, 2024

vlimant commented Mar 30, 2024

antoniovilela commented Mar 31, 2024

rappoccio commented Apr 1, 2024

cmsbuild commented Apr 1, 2024

malbouis commented Apr 1, 2024

antoniovilela commented Apr 2, 2024

antoniovilela commented Apr 2, 2024

antoniovilela commented Apr 2, 2024

cmsbuild commented Apr 2, 2024

Add custom filterbits for EGM Nano [14_0_X] #44524

Add custom filterbits for EGM Nano [14_0_X] #44524

Conversation

RSalvatico commented Mar 23, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 23, 2024

cmsbuild commented Mar 23, 2024 • edited Loading

RSalvatico commented Mar 23, 2024

RSalvatico commented Mar 23, 2024

RSalvatico commented Mar 23, 2024

cmsbuild commented Mar 23, 2024

Comparison Summary

NANO Comparison Summary

missirol Mar 23, 2024

Choose a reason for hiding this comment

RSalvatico Mar 25, 2024

Choose a reason for hiding this comment

missirol Mar 25, 2024

Choose a reason for hiding this comment

hqucms Apr 22, 2024

Choose a reason for hiding this comment

RSalvatico Apr 23, 2024

Choose a reason for hiding this comment

cmsbuild commented Mar 25, 2024

RSalvatico commented Mar 25, 2024

cmsbuild commented Mar 26, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

rappoccio commented Mar 28, 2024

RSalvatico commented Mar 28, 2024

vlimant commented Mar 30, 2024

antoniovilela commented Mar 31, 2024

rappoccio commented Apr 1, 2024

cmsbuild commented Apr 1, 2024

malbouis commented Apr 1, 2024

antoniovilela commented Apr 2, 2024

antoniovilela commented Apr 2, 2024

antoniovilela commented Apr 2, 2024

cmsbuild commented Apr 2, 2024

RSalvatico commented Mar 23, 2024 •

edited

Loading

cmsbuild commented Mar 23, 2024 •

edited

Loading