Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct one filterBit name in EGMNano and add one more #44809

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Correct one filterBit name in EGMNano and add one more #44809

merged 2 commits into from
Apr 24, 2024

Conversation

RSalvatico
Copy link
Contributor

PR description:

Make the final filter of HLT_Mu12_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoV consistent with the new naming convention, as pointed out by @missirol in #44524 (comment). The name had already been changed in 140X.

Moreover, I have added another filterBit for HLT_Ele115_CaloIdVT_GsfTrkIdT.

PR validation:

Nothing special to validate besides what was already done in #44496 and #44524.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Apr 23, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2024 •
edited
Loading

cms-bot internal usage

@RSalvatico RSalvatico mentioned this pull request Apr 23, 2024
Merged
@RSalvatico
Copy link
Contributor Author

type egamma

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44809/40059

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @RSalvatico for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

Moreover, I have added another filterBit for HLT_Ele115_CaloIdVT_GsfTrkIdT.

@RSalvatico This was not in 14_0_X, right? I suppose you would want a backport?

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

please test

@RSalvatico
Copy link
Contributor Author

Moreover, I have added another filterBit for HLT_Ele115_CaloIdVT_GsfTrkIdT.

@RSalvatico This was not in 14_0_X, right? I suppose you would want a backport?

I didn't think it was still possible, but if it is then I'll make it!

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

Moreover, I have added another filterBit for HLT_Ele115_CaloIdVT_GsfTrkIdT.

@RSalvatico This was not in 14_0_X, right? I suppose you would want a backport?

I didn't think it was still possible, but if it is then I'll make it!

@RSalvatico Please make one and we will see at today's ORP.

@RSalvatico RSalvatico mentioned this pull request Apr 23, 2024
Merged
@RSalvatico
Copy link
Contributor Author

Moreover, I have added another filterBit for HLT_Ele115_CaloIdVT_GsfTrkIdT.

@RSalvatico This was not in 14_0_X, right? I suppose you would want a backport?

I didn't think it was still possible, but if it is then I'll make it!

@RSalvatico Please make one and we will see at today's ORP.

Done, thanks. #44812

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3259e6/39024/summary.html
COMMIT: 121ba35
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44809/39024/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.39 3.51 -3.4% 2.174 2.260
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.16 3.14 +0.8% 2.559 2.688
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.25 3.24 +0.3% 2.539 2.661
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.07 6.03 +0.6% 2.290 2.282
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.29 3.28 +0.2% 2.451 2.467
2500.012 1.761 1.761 0.000 ( +0.0% ) 4.76 4.77 -0.1% 2.338 2.442
2500.1 2.354 2.354 0.000 ( +0.0% ) 4.49 4.43 +1.4% 1.984 2.075
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.17 5.08 +1.7% 1.891 1.982
2500.21 1.286 1.286 0.000 ( +0.0% ) 3.39 3.47 -2.2% 2.163 2.269
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.15 3.06 +2.9% 2.196 2.350
2500.3 2.229 2.229 0.000 ( +0.0% ) 9.80 9.24 +6.1% 1.893 1.969
2500.301 2.833 2.833 0.000 ( +0.0% ) 8.41 7.92 +6.2% 1.839 1.948
2500.31 7.164 7.164 0.000 ( +0.0% ) 1.38 1.38 +0.0% 1.704 1.702
2500.311 1.568 1.568 0.000 ( +0.0% ) 7.24 6.57 +10.2% 1.055 1.047
2500.312 540.457 540.457 0.000 ( +0.0% ) 0.53 0.50 +7.0% 1.601 1.589
2500.313 817.694 817.694 0.000 ( +0.0% ) 0.73 0.68 +7.4% 1.581 1.575
2500.32 1.348 1.348 0.000 ( +0.0% ) 12.69 12.15 +4.4% 2.325 2.335
2500.321 1.757 1.757 0.000 ( +0.0% ) 9.77 9.14 +6.9% 2.398 2.405
2500.322 1.236 1.236 0.000 ( +0.0% ) 10.16 9.58 +6.1% 2.102 2.129
2500.323 7.772 7.772 0.000 ( +0.0% ) 3.49 3.32 +5.2% 1.891 1.923
2500.324 1.874 1.873 0.001 ( +0.0% ) 9.99 9.37 +6.5% 2.162 2.170
2500.325 4.136 4.136 0.000 ( +0.0% ) 4.49 4.29 +4.4% 2.195 2.187
2500.326 3.342 3.342 0.000 ( +0.0% ) 1.68 1.60 +4.8% 2.093 1.914
2500.327 1.811 1.811 0.000 ( +0.0% ) 9.62 9.61 +0.0% 2.311 2.299
2500.4 2.374 2.374 0.000 ( +0.0% ) 9.25 8.26 +12.0% 1.802 1.784
2500.401 1.891 1.891 0.000 ( +0.0% ) 8.22 7.81 +5.2% 1.689 1.686
2500.402 2.950 2.950 0.000 ( +0.0% ) 8.02 7.57 +6.0% 1.763 1.779
2500.403 8.700 8.700 0.000 ( +0.0% ) 2.97 2.84 +4.7% 1.766 1.792
2500.404 5.474 5.474 0.000 ( +0.0% ) 1.21 1.18 +2.4% 1.805 1.767
2500.405 2.860 2.860 0.000 ( +0.0% ) 8.03 7.64 +5.1% 1.785 1.616
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.85 15.36 +3.2% 1.564 1.499
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.58 9.53 +0.5% 1.514 1.481

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8ba8ffe into cms-sw:master Apr 24, 2024
13 checks passed
@cmsbuild cmsbuild mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved egamma fully-signed orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@RSalvatico @cmsbuild @hqucms @antoniovilela