Update for simulation of pixel bad components #44395
Conversation
…mix stage2 The PixelFEDChannelCollection produced by the MixingModule in premix stage2 is not used at all so there is no point is creating it. Another PixelFEDChannelCollection is produced later by the DataMixer and propagated to tracking (after undergoing DigiToRaw and RawToDigi steps).
Up to now permanently bad components were killed prior to the DataMixer and separately for signal and pileup. For pileup this was happening in the MixingModule in stage 1 premixing and for signal in the MixingModule in stage 2 premixing. Instead, killing of transiently bad components was deferred to the last step in the DataMixer where signal and pileup digis are mixed. With this commit both permanently and transiently bad pixel components are killed in one place, in the DataMixer. This way premixed pileup library can be produced even before the list of bad components has been finalized and can later be reused with different bad component scenarios.
|
A new Pull Request was created by @ferencek for CMSSW_14_0_X. It involves the following packages:
@mdhildreth, @cmsbuild, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
type bug-fix |
|
@cmsbuild, please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4021a4/38116/summary.html Comparison SummarySummary:
|
cmsbuild
added
simulation-approved
fully-signed
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1
|
PR description:
This is a backport of #44276 and #44320. The primary goal was to backport #44320 but to be able to cherry-pick its commit from the CMSSW_14_1_X branch, #44276 had to be cherry-picked first (they both modify
SimGeneral/MixingModule/python/pixelDigitizer_cfi.py).This PR is relevant for the Run 3 MC production.
@sroychow