Kill both permanently and transiently bad pixel components in DataMixer #44320
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44320/39344
|
|
A new Pull Request was created by @ferencek for master. It involves the following packages:
@civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Does this work as well for classical mixing? |
Classical (full) mixing remains intact by this PR. |
Up to now permanently bad components were killed prior to the DataMixer and separately for signal and pileup. For pileup this was happening in the MixingModule in stage 1 premixing and for signal in the MixingModule in stage 2 premixing. Instead, killing of transiently bad components was deferred to the last step in the DataMixer where signal and pileup digis are mixed. With this commit both permanently and transiently bad pixel components are killed in one place, in the DataMixer. This way premixed pileup library can be produced even before the list of bad components has been finalized and can later be reused with different bad component scenarios.
ferencek
force-pushed
the
killModules_in_DataMixer
branch
from
a9a3039 to
cec8d84
Compare
|
Branch rebased to resolve conflict after #44276 got merged. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44320/39346
|
|
Pull request #44320 was updated. @civanch, @mdhildreth, @cmsbuild can you please check and sign again. |
|
@ferencek , may be "draft" should be removed? |
I agree. Done. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-114bd4/37957/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Up to now permanently bad components were killed prior to the DataMixer and separately for signal and pileup. For pileup this was happening in the MixingModule in stage 1 premixing and for signal in the MixingModule in stage 2 premixing. Instead, killing of transiently bad components was deferred to the last step in the DataMixer where signal and pileup digis are mixed. With this commit both permanently and transiently bad pixel components are killed in one place, in the DataMixer. This way premixed pileup library can be produced even before the list of bad components has been finalized and can later be reused (within the same production campaign) even with different bad component scenarios. The proposed change was presented in the Pixel Offline Meeting on Mar. 5, 2024 and the presentation can be found here.
PR validation:
Tested before and after the change using wf 250202.181 to confirm that permanently dead components are killed in both cases.
If this PR will be backported please specify to which release cycle the backport is meant for:
Backport to CMSSW_14_0_X is foreseen. Since this PR had a merge conflict with #44276, which had been resolved in the meantime, it might be best to backport both PRs together since they are somewhat related anyways.
@sroychow