Skip to content

Commit

Permalink
kill both permanently and transiently bad pixel components in DataMixer
Browse files Browse the repository at this point in the history
Up to now permanently bad components were killed prior to the DataMixer
and separately for signal and pileup. For pileup this was happening in
the MixingModule in stage 1 premixing and for signal in the MixingModule
in stage 2 premixing. Instead, killing of transiently bad components was
deferred to the last step in the DataMixer where signal and pileup digis
are mixed. With this commit both permanently and transiently bad pixel
components are killed in one place, in the DataMixer. This way premixed
pileup library can be produced even before the list of bad components
has been finalized and can later be reused with different bad component
scenarios.
  • Loading branch information
ferencek committed Mar 13, 2024
1 parent 92818f7 commit 7b6407e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions SimGeneral/MixingModule/python/SiPixelSimParameters_cfi.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def _modifyPixelDigitizerForRun3( digitizer ):
AddNoisyPixels = False,
AddPixelInefficiency = False, #done in second step
KillBadFEDChannels = False, #done in second step
killModules = False #done in second step
)

# Threshold in electrons are the Official CRAFT09 numbers:
Expand Down
3 changes: 2 additions & 1 deletion SimGeneral/MixingModule/python/pixelDigitizer_cfi.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
from Configuration.ProcessModifiers.premix_stage2_cff import premix_stage2
premix_stage2.toModify(pixelDigitizer,
AddPixelInefficiency = False, # will be added in DataMixer
KillBadFEDChannels = False # will be added in DataMixer
KillBadFEDChannels = False, # will be added in DataMixer
killModules = False # will be added in DataMixer
)

from SimTracker.SiPhase2Digitizer.phase2TrackerDigitizer_cfi import phase2TrackerDigitizer as _phase2TrackerDigitizer, _premixStage1ModifyDict
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
# To preserve the behaviour of copy-pasted version of premix worker
# All these are done in stage1 (for both signal and pileup)
AddNoise = False,
killModules = False,
MissCalibrate = False,
),
workerType = cms.string("PreMixingSiPixelWorker"),
Expand Down

0 comments on commit 7b6407e

Please sign in to comment.