-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] add input / output LA TkDetMaps
in SiStripLorentzAnglePCLHarvester
#44378
[14.0.X] add input / output LA TkDetMaps
in SiStripLorentzAnglePCLHarvester
#44378
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@consuegs, @saumyaphor4252, @perrotta, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1281c/38063/summary.html Comparison SummarySummary:
|
@cms-sw/alca-l2 kind ping here: |
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #44370
PR description:
This is a quick follow-up to #44030. Title says it all, add
TkDetMaps
for module-level inspection of input and output LA values.Additionally do not write a payload if the output value is identically 0.
PR validation:
Run on 3.8T run with data from the Strip Tracker via:
cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripLA \ --conditions 140X_dataRun3_Express_v2 \ --scenario cosmics \ --data \ --era Run3_2023 \ -n -1 \ --dasquery='file dataset=/StreamExpressCosmics/Run2023F-PromptCalibProdSiStripLA-Express-v1/ALCAPROMPT run=373245'
and checked the output maps are filled correctly.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #44370 for the 2024 data-taking release.