Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] add input / output LA TkDetMaps in SiStripLorentzAnglePCLHarvester #44378

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 12, 2024

backport of #44370

PR description:

This is a quick follow-up to #44030. Title says it all, add TkDetMaps for module-level inspection of input and output LA values.
Additionally do not write a payload if the output value is identically 0.

PR validation:

Run on 3.8T run with data from the Strip Tracker via:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripLA \
	     --conditions 140X_dataRun3_Express_v2 \
	     --scenario cosmics \
	     --data \
	     --era Run3_2023 \
	     -n -1 \
	     --dasquery='file dataset=/StreamExpressCosmics/Run2023F-PromptCalibProdSiStripLA-Express-v1/ALCAPROMPT run=373245'

and checked the output maps are filled correctly.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44370 for the 2024 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • CalibTracker/SiStripCommon (alca)
  • CalibTracker/SiStripLorentzAngle (alca)

@consuegs, @saumyaphor4252, @perrotta, @cmsbuild can you please review it and eventually sign? Thanks.
@rsreds, @robervalwalsh, @mmusich, @tocheng, @echabert, @gbenelli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1281c/38063/summary.html
COMMIT: 5c52f77
CMSSW: CMSSW_14_0_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44378/38063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 44 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3342271
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342249
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2024

@cms-sw/alca-l2 kind ping here: CMSSW_14_1_X_2024-03-13-2300 (containing the master version of this PR #44370 ) looks fine in terms of tests: https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_14_1_X

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c308573 into cms-sw:CMSSW_14_0_X Mar 14, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_SiStripLA_tkDetMaps_14_0_X branch March 14, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants