Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Update SiStripLorentzAnglePCLHarvester to avoid writing useless payloads and more control plots #44030

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 20, 2024

backport of #43962

PR description:

With the restart of the 2024 cosmic data-taking operations, I noticed that the SiStripLorentzAngle PCL workflow is uploading a payload essentially for every run (see conditions uploader logs), even if the Strip Tracker is not joining the data-taking. This happens because, by default, if no new measurement is available the producer inserts in the database a new IoV copying the values of the currently used payload (see payloads in SiStripLorentzAngle_byPCL_v0_prompt).
I change this behavior such that it doesn't write out a new payload if there isn't at least a new measurement from one of the partitions. In addition I add some control plots in the SiStripLorentzAnglePCLHarvester module to display the output Lorentz Angle payload values per layer and module type (if there's a successful measurement) and the diff w.r.t. the one used in input.

PR validation:

Run both with 3.8T run with data from the Strip Tracker via:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripLA \
	     --conditions 140X_dataRun3_Express_v2 \
	     --scenario pp \
	     --data \
	     --era Run3_2023 \
	     -n -1 \
	     --dasquery='file dataset=/StreamExpressCosmics/Run2023F-PromptCalibProdSiStripLA-Express-v1/ALCAPROMPT run=373245'

and with 0T data without Tracker (from a recent run 376727) via:

cmsDriver.yp stepHarvest2024 -s ALCAHARVEST:SiStripLA \
	     --conditions 140X_dataRun3_Express_v2 \
	     --scenario pp \
	     --data \
	     --era Run3 \
	     -n -1 \
	     --dasquery='file dataset=/StreamExpressCosmics/Commissioning2024-PromptCalibProdSiStripLA-Express-v1/ALCAPROMPT run=376727'

and obtained sensible results. In particular the second test doesn't produce an output payload, while in the first the following plot was produced:

Value Diff [%]
Screenshot from 2024-02-14 13-41-33 Screenshot from 2024-02-14 13-44-01

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43962 to CMSSW_14_0_X for 2024 operations.

@mmusich mmusich changed the title [14.0.X] Update SiStripLorentzAnglePCLHarvester to avoid writing useless payloads and more control plots [14.0.X] Update SiStripLorentzAnglePCLHarvester to avoid writing useless payloads and more control plots Feb 20, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Feb 20, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • CalibTracker/SiStripLorentzAngle (alca)

@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@echabert, @rchatter, @robervalwalsh, @mmusich, @thomreis, @yuanchao, @gbenelli, @ReyerBand, @wang0jin, @rsreds, @tocheng, @argiro this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 20, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Feb 20, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Feb 20, 2024

test parameters:

  • workflow = 1005.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cecc4/37582/summary.html
COMMIT: 1b12a17
CMSSW: CMSSW_14_0_X_2024-02-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44030/37582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2024

urgent

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9f3c8af into cms-sw:CMSSW_14_0_X Feb 21, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_updates_SiStripLorentzAnglePCLHarvester_14_0_X branch February 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants