Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input / output LA TkDetMaps in SiStripLorentzAnglePCLHarvester #44370

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 11, 2024

PR description:

This is a quick follow-up to #43962. Title says it all, add TkDetMaps for module-level inspection of input and output LA values.
Additionally do not write a payload if the output value is identically 0.

PR validation:

Run on 3.8T run with data from the Strip Tracker via:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripLA \
	     --conditions 140X_dataRun3_Express_v2 \
	     --scenario cosmics \
	     --data \
	     --era Run3_2023 \
	     -n -1 \
	     --dasquery='file dataset=/StreamExpressCosmics/Run2023F-PromptCalibProdSiStripLA-Express-v1/ALCAPROMPT run=373245'

and checked the output maps are filled correctly.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_14_0_X for data-taking purposes

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44370/39418

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CalibTracker/SiStripLorentzAngle (alca)

@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@tocheng, @echabert, @robervalwalsh, @mmusich, @rsreds, @gbenelli, @yuanchao this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44370/39426

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44370 was updated. @saumyaphor4252, @consuegs, @cmsbuild, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2024

@cmsbuild, please test

@mmusich mmusich changed the title add input / output LA TkDetMaps in SiStripLorentzAnglePCLHarvester add input / output LA TkDetMaps in SiStripLorentzAnglePCLHarvester Mar 12, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77a0fd/38052/summary.html
COMMIT: 0e4e3bd
CMSSW: CMSSW_14_1_X_2024-03-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44370/38052/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 66 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 1353
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3296010
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants