Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values in {CaloRecHitSoA,PFRecHitSoA,LegacyPFRecHit,PFClusterSoA}Producer::fillDescriptions [14_0_X] #44291

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Mar 3, 2024

backport of #44290

PR description:

From the description of #44290:

This PR adds default values for parameters currently missing them in {CaloRecHitSoA,PFRecHitSoA,LegacyPFRecHit,PFClusterSoA}Producer::fillDescriptions.

This is necessary in order to use these plugins in ConfDB for HLT-menu development (these plugins are part of the latest Alpaka developments for HLT, see customizeHLTforAlpakaParticleFlowClustering).

FYI: @cms-sw/hlt-l2

PR validation:

None beyond the checks done for #44290.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#44290

Necessary for the integration of Alpaka modules in the 2024 HLT menus.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2024

A new Pull Request was created by @missirol for CMSSW_14_0_X.

It involves the following packages:

  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@lgray, @hatakeyamak, @rovere, @seemasharmafnal, @felicepantaleo, @sameasy, @mmarionncern this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor

please test

@Martin-Grunewald
Copy link
Contributor

urgent

@cmsbuild cmsbuild added the urgent label Mar 4, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52e214/37869/summary.html
COMMIT: 8e6c70f
CMSSW: CMSSW_14_0_X_2024-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44291/37869/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338820
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338795
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 639cc20 into cms-sw:CMSSW_14_0_X Mar 5, 2024
21 checks passed
@missirol missirol deleted the devel_fillDescCaloRecHit branch March 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants