Add default values in {CaloRecHitSoA,PFRecHitSoA,LegacyPFRecHit,PFClusterSoA}Producer::fillDescriptions

[missirol]

PR description:

This PR adds default values for parameters currently missing them in {CaloRecHitSoA,PFRecHitSoA,LegacyPFRecHit,PFClusterSoA}Producer::fillDescriptions.

This is necessary in order to use these plugins in ConfDB for HLT-menu development (these plugins are part of the latest Alpaka developments for HLT, see customizeHLTforAlpakaParticleFlowClustering).

FYI: @cms-sw/hlt-l2

PR validation:

Visual inspection of the auto-generated cfi files after including these changes.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_14_0_X

Necessary for the integration of Alpaka modules in the 2024 HLT menus.

[cmsbuild]

cms-bot internal usage

[missirol]

Example of one of the auto-generated cfi files for this plugin in CMSSW_14_0_0_pre3.

import FWCore.ParameterSet.Config as cms

pfRecHitSoAProducerHCAL = cms.EDProducer('PFRecHitSoAProducerHCAL@alpaka',
  producers = cms.VPSet(
    cms.PSet(
      src = cms.InputTag('')
    )
  ),
  topology = cms.ESInputTag('', ''),
  synchronise = cms.untracked.bool(False),
  mightGet = cms.optional.untracked.vstring,
  alpaka = cms.untracked.PSet(
    backend = cms.untracked.string('')
  )
)

I could not get params to be added under producers, despite the fact that its default value is specified in fillDescriptions, so I am missing something.

It might be that this is not an issue for ConfDB parsing, if nested PSets like this one can be edited in ConfDB regardless of these defaults parameters. I'm not 100% sure this is the case, though.

If I change the type of params from edm::ESInputTag to something else (I tried std::string), then it does appear as intended inside the producers VPSet of the auto-generated cfi file.

[Martin-Grunewald]

As mentioned in mattermost, this should be sufficient for the ConfDB side.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44290/39312

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @missirol for master.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)
• RecoParticleFlow/PFRecHitProducer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@rovere, @lgray, @mmarionncern, @hatakeyamak, @felicepantaleo, @seemasharmafnal, @sameasy this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[Martin-Grunewald]

urgent

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-805393/37868/summary.html
COMMIT: 8e6c70f
CMSSW: CMSSW_14_1_X_2024-03-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44290/37868/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 86 lines from the logs
• Reco comparison results: 58 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338784
• DQMHistoTests: Total failures: 1355
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337407
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1