Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values in {CaloRecHitSoA,PFRecHitSoA,LegacyPFRecHit,PFClusterSoA}Producer::fillDescriptions [14_0_X] #44291

Merged
merged 1 commit into from
Mar 5, 2024
+13 −10
Merged

Add default values in {CaloRecHitSoA,PFRecHitSoA,LegacyPFRecHit,PFClusterSoA}Producer::fillDescriptions [14_0_X] #44291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFClusterSoAProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {

static void fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
desc.add<edm::InputTag>("pfRecHits");
desc.add<edm::ESInputTag>("pfClusterParams");
desc.add<edm::ESInputTag>("topology");
desc.add<bool>("synchronise");
desc.add<edm::InputTag>("pfRecHits", edm::InputTag(""));
desc.add<edm::ESInputTag>("pfClusterParams", edm::ESInputTag(""));
desc.add<edm::ESInputTag>("topology", edm::ESInputTag(""));
desc.add<bool>("synchronise", false);
desc.add<int>("pfRecHitFractionAllocation", 120);
descriptions.addWithDefaultLabel(desc);
}
Expand Down
2 changes: 1 addition & 1 deletion RecoParticleFlow/PFRecHitProducer/plugins/LegacyPFRecHitProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class LegacyPFRecHitProducer : public edm::stream::EDProducer<> {

static void fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
desc.add<edm::InputTag>("src");
desc.add<edm::InputTag>("src", edm::InputTag(""));
descriptions.addWithDefaultLabel(desc);
}

Expand Down
2 changes: 1 addition & 1 deletion RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CaloRecHitSoAProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {

static void fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
desc.add<edm::InputTag>("src")->setComment("Input calorimeter rec hit collection");
desc.add<edm::InputTag>("src", edm::InputTag(""))->setComment("Input calorimeter rec hit collection");
desc.addUntracked<bool>("synchronise", false)
->setComment("Add synchronisation point after execution (for benchmarking asynchronous execution)");
descriptions.addWithDefaultLabel(desc);
Expand Down
11 changes: 7 additions & 4 deletions RecoParticleFlow/PFRecHitProducer/plugins/alpaka/PFRecHitSoAProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,13 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
static void fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;
edm::ParameterSetDescription producers;
producers.add<edm::InputTag>("src")->setComment("Input CaloRecHitSoA");
producers.add<edm::ESInputTag>("params")->setComment("Quality cut parameters");
desc.addVPSet("producers", producers)->setComment("List of inputs and quality cuts");
desc.add<edm::ESInputTag>("topology")->setComment("Topology information");
producers.add<edm::InputTag>("src", edm::InputTag(""))->setComment("Input CaloRecHitSoA");
producers.add<edm::ESInputTag>("params", edm::ESInputTag(""))->setComment("Quality cut parameters");
std::vector<edm::ParameterSet> producersDefault(1);
producersDefault[0].addParameter<edm::InputTag>("src", edm::InputTag(""));
producersDefault[0].addParameter<edm::ESInputTag>("params", edm::ESInputTag(""));
desc.addVPSet("producers", producers, producersDefault)->setComment("List of inputs and quality cuts");
desc.add<edm::ESInputTag>("topology", edm::ESInputTag(""))->setComment("Topology information");
desc.addUntracked<bool>("synchronise", false)
->setComment("Add synchronisation point after execution (for benchmarking asynchronous execution)");
descriptions.addWithDefaultLabel(desc);
Expand Down