-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two more PV variables requested by H->gammagamma conveners #44285
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44285/39305
|
A new Pull Request was created by @JunquanTao for master. It involves the following packages:
@cmsbuild, @vlimant, @hqucms can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@JunquanTao Please add the new variables to nanoDQM. |
enable nano |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44285/39321
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44285/39323
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d07f5e/37889/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
@JunquanTao Please make a backport to 14_0_X for Nano V14 production. |
@hqucms Should I submit a new PR with CMSSW 14_0_X? |
@JunquanTao Yes please do. Thanks a lot! |
+1 |
|
PR description:
This PR is to add the PV sum_px and sum_py of pf charged particles associated to PV in NanoAOD, as suggested by Hgg conveners @lfinco , @fcouderc , for the vertex probability estimator.
Since 2 variables (float type) for each event are proposed to add, the expected additional size in nanoAOD will be 2-3 bytes per event, depending on the precision to store this variable (8 or 10 bits). By default we propose to store it in the precision with 10 bits.
PR validation:
runTheMatrix tests have been successfully run for the following workflow :
• runTheMatrix.py -l 12434.0
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
We target this to go in the next nano production, V14 .