Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more PV variables requested by H->gammagamma conveners #44285

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

JunquanTao
Copy link
Contributor

PR description:

This PR is to add the PV sum_px and sum_py of pf charged particles associated to PV in NanoAOD, as suggested by Hgg conveners @lfinco , @fcouderc , for the vertex probability estimator.

Since 2 variables (float type) for each event are proposed to add, the expected additional size in nanoAOD will be 2-3 bytes per event, depending on the precision to store this variable (8 or 10 bits). By default we propose to store it in the precision with 10 bits.

PR validation:

runTheMatrix tests have been successfully run for the following workflow :
• runTheMatrix.py -l 12434.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We target this to go in the next nano production, V14 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44285/39305

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

A new Pull Request was created by @JunquanTao for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @vlimant, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Mar 1, 2024

@JunquanTao Please add the new variables to nanoDQM.

@hqucms
Copy link
Contributor

hqucms commented Mar 1, 2024

enable nano

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44285/39321

  • This PR adds an extra 32KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

Pull request #44285 was updated. @hqucms, @vlimant, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44285/39323

  • This PR adds an extra 32KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2024

Pull request #44285 was updated. @cmsbuild, @hqucms, @vlimant can you please check and sign again.

@hqucms
Copy link
Contributor

hqucms commented Mar 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d07f5e/37889/summary.html
COMMIT: bea4c11
CMSSW: CMSSW_14_1_X_2024-03-04-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44285/37889/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 54 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3339090
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3339062
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.600000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.225 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.150000000000001 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.225 KiB Physics/NanoAODDQM
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.555 2.551 0.004 ( +0.2% ) 5.07 5.18 -2.1% 2.168 2.186
2500.001 2.705 2.700 0.004 ( +0.2% ) 4.58 4.61 -0.6% 2.585 2.621
2500.002 2.646 2.641 0.005 ( +0.2% ) 4.75 4.83 -1.6% 2.572 2.617
2500.01 1.326 1.322 0.004 ( +0.3% ) 9.14 9.27 -1.4% 2.271 2.286
2500.011 1.749 1.745 0.004 ( +0.2% ) 5.10 5.08 +0.4% 2.469 2.435
2500.012 1.590 1.586 0.004 ( +0.3% ) 7.28 7.25 +0.5% 2.365 2.362
2500.1 2.198 2.194 0.004 ( +0.2% ) 5.31 5.18 +2.5% 1.980 2.088
2500.2 2.314 2.310 0.004 ( +0.2% ) 6.07 5.99 +1.4% 1.881 2.001
2500.21 1.190 1.186 0.004 ( +0.4% ) 4.34 4.27 +1.5% 2.180 2.281
2500.211 1.554 1.550 0.005 ( +0.3% ) 3.75 3.53 +6.2% 2.209 2.252
2500.3 2.065 2.061 0.004 ( +0.2% ) 12.53 12.03 +4.2% 1.888 1.916
2500.301 2.639 2.634 0.005 ( +0.2% ) 10.08 9.35 +7.9% 1.817 1.853
2500.31 1.269 1.264 0.004 ( +0.3% ) 19.99 18.97 +5.4% 2.249 2.303
2500.311 1.643 1.638 0.005 ( +0.3% ) 12.37 11.60 +6.6% 2.254 2.359
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.40 1.33 +5.1% 1.680 1.711
2500.313 1.564 1.564 0.000 ( +0.0% ) 7.24 5.92 +22.4% 1.065 1.054
2500.314 1.165 1.161 0.005 ( +0.4% ) 13.34 12.04 +10.8% 2.041 2.063
2500.315 1.763 1.759 0.005 ( +0.3% ) 13.00 11.55 +12.6% 2.180 2.341
2500.4 2.065 2.061 0.004 ( +0.2% ) 12.43 12.07 +3.0% 1.846 1.880
2500.401 1.822 1.818 0.005 ( +0.3% ) 10.49 9.40 +11.7% 1.707 1.705
2500.402 2.639 2.634 0.005 ( +0.2% ) 9.99 9.03 +10.6% 1.771 1.780
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.23 1.11 +11.1% 1.292 1.142

@hqucms
Copy link
Contributor

hqucms commented Mar 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@hqucms
Copy link
Contributor

hqucms commented Mar 5, 2024

@JunquanTao Please make a backport to 14_0_X for Nano V14 production.

@JunquanTao
Copy link
Contributor Author

@JunquanTao Please make a backport to 14_0_X for Nano V14 production.

@hqucms Should I submit a new PR with CMSSW 14_0_X?

@hqucms
Copy link
Contributor

hqucms commented Mar 5, 2024

@JunquanTao Please make a backport to 14_0_X for Nano V14 production.

@hqucms Should I submit a new PR with CMSSW 14_0_X?

@JunquanTao Yes please do. Thanks a lot!

@rappoccio
Copy link
Contributor

+1

@JunquanTao
Copy link
Contributor Author

@JunquanTao Please make a backport to 14_0_X for Nano V14 production.

@hqucms Should I submit a new PR with CMSSW 14_0_X?

@JunquanTao Yes please do. Thanks a lot!

@hqucms Please review it: #44325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants