PFMet and PuppiMET Branches

[wajidalikhan]

PR description:

• PFMet and PuppiMET do not have the same variables stored in NanoAOD
• Idea is to have a consistent variables stored in both the PFMET and PuppiMET at the NanoAOD for next data taking
• Remove / Rename some of the other relevant branches

[cmsbuild]

cms-bot internal usage

[vlimant]

enable nano

[vlimant]

@wajidalikhan please modify the description with relevant information

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44038/38975

• This PR adds an extra 32KB to repository

[vlimant]

please test

[cmsbuild]

A new Pull Request was created by @wajidalikhan for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9058c/37593/summary.html
COMMIT: ed7872c
CMSSW: CMSSW_14_1_X_2024-02-20-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44038/37593/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 184 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3246946
• DQMHistoTests: Total failures: 1198
• DQMHistoTests: Total nulls: 15
• DQMHistoTests: Total successes: 3245711
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -181.26600000000002 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -14.485 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): -10.484 KiB Physics/NanoAODDQM
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 350 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 15187
• DQMHistoTests: Total failures: 50
• DQMHistoTests: Total nulls: 14
• DQMHistoTests: Total successes: 15123
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -165.433 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): -14.508 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.011,... ): -10.507 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.1,... ): -11.612 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.211,... ): -8.613 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.311,... ): -10.484 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 2500.3,... ): -14.485 KiB Physics/NanoAODDQM
• Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.537	2.551	-0.014 ( -0.5% )	5.29	5.17	+2.4%	2.225	2.159
2500.001	2.686	2.700	-0.014 ( -0.5% )	4.73	4.65	+1.8%	2.665	2.589
2500.002	2.622	2.641	-0.019 ( -0.7% )	4.93	4.82	+2.4%	2.658	2.589
2500.01	1.314	1.322	-0.009 ( -0.6% )	9.76	9.45	+3.3%	2.342	2.270
2500.011	1.735	1.745	-0.010 ( -0.6% )	5.27	5.17	+2.0%	2.533	2.427
2500.012	1.577	1.586	-0.009 ( -0.6% )	7.63	7.35	+3.8%	2.432	2.353
2500.1	2.182	2.194	-0.012 ( -0.5% )	5.32	5.30	+0.5%	2.065	1.992
2500.2	2.297	2.310	-0.013 ( -0.6% )	6.06	6.07	-0.0%	1.982	1.898
2500.21	1.177	1.185	-0.008 ( -0.7% )	4.33	4.32	+0.2%	2.277	2.216
2500.211	1.539	1.549	-0.010 ( -0.6% )	3.78	3.71	+1.9%	2.356	2.222
2500.3	2.047	2.060	-0.013 ( -0.6% )	12.70	12.55	+1.2%	1.960	1.891
2500.31	1.249	1.257	-0.009 ( -0.7% )	20.00	19.81	+1.0%	2.373	2.294
2500.311	1.637	1.646	-0.009 ( -0.6% )	12.43	12.03	+3.4%	2.439	2.316
2500.312	7.159	7.159	0.000 ( +0.0% )	1.42	1.34	+5.5%	1.685	1.690
2500.313	1.564	1.564	0.000 ( +0.0% )	5.86	5.56	+5.2%	1.045	1.036
2500.4	2.047	2.060	-0.013 ( -0.6% )	12.74	12.58	+1.3%	1.964	1.896
2500.5	19.575	19.575	0.000 ( +0.0% )	1.20	1.20	-0.3%	1.354	1.124

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44038/39000

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #44038 was updated. @cmsbuild, @vlimant, @hqucms can you please check and sign again.

[hqucms]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9058c/37896/summary.html
COMMIT: 8504ea7
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44038/37896/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 148 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338626
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 16
• DQMHistoTests: Total successes: 3338582
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -7.024 KiB( 48 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.439 KiB Physics/NanoAODDQM
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 392 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16024
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 14
• DQMHistoTests: Total successes: 16010
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -6.146 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): -0.439 KiB Physics/NanoAODDQM
• Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.544	2.551	-0.007 ( -0.3% )	5.27	3.68	+43.2%	2.181	2.260
2500.001	2.693	2.700	-0.007 ( -0.3% )	4.71	3.30	+42.6%	2.610	2.698
2500.002	2.631	2.641	-0.009 ( -0.3% )	4.86	3.42	+42.2%	2.604	2.675
2500.01	1.314	1.322	-0.009 ( -0.6% )	9.61	7.00	+37.2%	2.281	2.377
2500.011	1.735	1.745	-0.010 ( -0.6% )	5.18	3.84	+34.8%	2.415	2.563
2500.012	1.577	1.586	-0.009 ( -0.6% )	7.42	5.40	+37.4%	2.363	2.469
2500.1	2.188	2.194	-0.006 ( -0.3% )	5.28	3.68	+43.7%	2.083	2.089
2500.2	2.303	2.310	-0.007 ( -0.3% )	6.10	4.27	+43.0%	1.995	2.007
2500.21	1.178	1.186	-0.008 ( -0.7% )	4.36	3.13	+39.1%	2.285	2.302
2500.211	1.540	1.550	-0.010 ( -0.6% )	3.76	2.63	+42.8%	2.282	2.382
2500.3	2.053	2.061	-0.007 ( -0.4% )	12.62	8.20	+53.9%	1.990	1.960
2500.301	2.626	2.634	-0.008 ( -0.3% )	9.87	6.71	+47.0%	1.970	1.948
2500.31	1.256	1.264	-0.008 ( -0.7% )	19.85	14.28	+39.0%	2.312	2.349
2500.311	1.628	1.638	-0.010 ( -0.6% )	12.48	9.01	+38.4%	2.343	2.424
2500.312	7.159	7.159	0.000 ( +0.0% )	1.43	1.00	+43.4%	1.713	1.399
2500.313	1.564	1.564	0.000 ( +0.0% )	6.90	5.27	+30.9%	1.068	1.058
2500.314	1.161	1.161	0.000 ( +0.0% )	13.12	9.53	+37.7%	2.075	2.228
2500.315	1.749	1.759	-0.010 ( -0.6% )	12.63	9.27	+36.3%	2.345	2.380
2500.4	2.053	2.061	-0.007 ( -0.4% )	12.46	8.35	+49.3%	1.883	1.996
2500.401	1.820	1.818	0.002 ( +0.1% )	10.53	6.96	+51.4%	1.836	1.837
2500.402	2.626	2.634	-0.008 ( -0.3% )	9.64	6.96	+38.5%	1.805	1.986
2500.5	19.575	19.575	0.000 ( +0.0% )	1.10	0.88	+25.8%	1.262	1.366

[hqucms]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9058c/37913/summary.html
COMMIT: 8504ea7
CMSSW: CMSSW_14_1_X_2024-03-05-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44038/37913/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 161 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3293028
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 16
• DQMHistoTests: Total successes: 3291640
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -7.024 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -0.439 KiB Physics/NanoAODDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 392 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16052
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 14
• DQMHistoTests: Total successes: 16038
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -6.146 KiB( 14 files compared)
• DQMHistoSizes: changed ( 2500.001,... ): -0.439 KiB Physics/NanoAODDQM
• Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.548	2.555	-0.007 ( -0.3% )	5.27	5.12	+2.9%	2.245	2.246
2500.001	2.698	2.705	-0.007 ( -0.3% )	4.71	4.60	+2.4%	2.680	2.625
2500.002	2.638	2.646	-0.008 ( -0.3% )	4.87	4.72	+3.0%	2.664	2.651
2500.01	1.318	1.326	-0.008 ( -0.6% )	9.72	9.25	+5.1%	2.321	2.285
2500.011	1.740	1.749	-0.009 ( -0.5% )	5.26	5.10	+3.1%	2.471	2.456
2500.012	1.581	1.590	-0.009 ( -0.6% )	7.55	7.14	+5.8%	2.381	2.393
2500.1	2.192	2.198	-0.006 ( -0.3% )	5.31	5.16	+2.9%	2.087	2.087
2500.2	2.308	2.314	-0.006 ( -0.3% )	6.07	5.86	+3.6%	2.005	1.999
2500.21	1.181	1.190	-0.009 ( -0.7% )	4.32	4.23	+2.2%	2.282	2.281
2500.211	1.545	1.554	-0.010 ( -0.6% )	3.74	3.42	+9.3%	2.367	2.373
2500.3	2.058	2.065	-0.007 ( -0.3% )	12.63	11.73	+7.7%	1.992	1.991
2500.301	2.631	2.639	-0.008 ( -0.3% )	10.31	9.12	+13.0%	1.978	1.973
2500.31	1.260	1.269	-0.008 ( -0.7% )	19.93	18.27	+9.1%	2.369	2.382
2500.311	1.633	1.643	-0.010 ( -0.6% )	12.43	11.39	+9.2%	2.467	2.466
2500.312	7.159	7.159	0.000 ( +0.0% )	1.44	1.25	+16.0%	1.714	1.712
2500.313	1.564	1.564	0.000 ( +0.0% )	6.44	6.54	-1.5%	1.066	1.059
2500.314	1.165	1.165	0.000 ( +0.0% )	13.01	11.58	+12.4%	2.096	2.080
2500.315	1.753	1.763	-0.010 ( -0.6% )	12.59	11.83	+6.4%	2.352	2.352
2500.4	2.058	2.065	-0.007 ( -0.3% )	12.55	11.68	+7.5%	1.905	1.885
2500.401	1.824	1.822	0.002 ( +0.1% )	10.39	9.47	+9.7%	1.836	1.835
2500.402	2.631	2.639	-0.008 ( -0.3% )	9.28	8.82	+5.2%	1.811	1.813
2500.5	19.575	19.575	0.000 ( +0.0% )	1.14	1.02	+11.4%	1.158	1.156

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1