Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFMet and PuppiMET Branches: Backport to CMSSW_141X #44383

Closed
wants to merge 10 commits into from

Conversation

wajidalikhan
Copy link
Contributor

@wajidalikhan wajidalikhan commented Mar 13, 2024

PR description:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44383/39444

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wajidalikhan for master.

It involves the following packages:

  • DQM/Physics (dqm)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@hqucms, @tjavaid, @vlimant, @nothingface0, @syuvivida, @jfernan2, @cmsbuild, @rvenditti, @antoniovagnerini, @mandrenguyen can you please review it and eventually sign? Thanks.
@gkasieczka, @rappoccio, @andrzejnovak, @demuller, @gouskos, @seemasharmafnal, @mbluj, @gpetruc, @azotz, @mariadalfonso, @Senphy, @mmarionncern, @hatakeyamak, @jdamgov, @JyothsnaKomaragiri, @Ming-Yan, @emilbols, @jdolen, @ahinzmann, @AlexDeMoor, @schoef, @AnnikaStein, @nhanvtran this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Mar 13, 2024

@wajidalikhan I think this is a backport of #44335, not #44038. Please update the PR title and description accordingly.

@wajidalikhan
Copy link
Contributor Author

wajidalikhan commented Mar 13, 2024

Hi @hqucms, there are two separate PR going on. this one #44038 which is about the renaming the nanoAOD branch. While the second one dealing with MiniAOD clean up #44335 which is still pending, hasn't been merged yet.

@mandrenguyen
Copy link
Contributor

Hi @hqucms, there are two separate PR going on. this one One MiniAOD Clean up , BTW this is still pending, hasn't been merged yet. The other one is dealing with MiniAOD clean up and other one is dealing with renaming or updating MET branches in NanoAOD

Can you please update the PR description though? Please keep the list of PRs explicit rather than hiding the PR#s in hyper-lnks.

@mandrenguyen
Copy link
Contributor

The milestone seems to be set to 14_1_X rather than 14_0_X

@wajidalikhan wajidalikhan changed the title PFMet and PuppiMET Branches: Backport to CMSSW_140X PFMet and PuppiMET Branches: Backport to CMSSW_141X Mar 14, 2024
@vlimant
Copy link
Contributor

vlimant commented Mar 15, 2024

please overhaul this backport (cherry pick the proper commit and make it against 14_0_X) asap @wajidalikhan

@hqucms
Copy link
Contributor

hqucms commented Mar 20, 2024

The 14_0_X backport is done in #44495.
@wajidalikhan Can you close this one?

@vlimant
Copy link
Contributor

vlimant commented Mar 21, 2024

please close

@cmsbuild cmsbuild closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants