Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_14_0_X] Add two more PV variables requested by H->gammagamma c… #44325

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

JunquanTao
Copy link
Contributor

…onveners

PR description:

This PR is to add the PV sum_px and sum_py of pf charged particles associated to PV in NanoAOD, as suggested by Hgg conveners @lfinco , @fcouderc , for the vertex probability estimator.

Since 2 variables (float type) for each event are proposed to add, the expected additional size in nanoAOD will be 2-3 bytes per event, depending on the precision to store this variable (8 or 10 bits). By default we propose to store it in the precision with 10 bits.

Ref: #44285

PR validation:

runTheMatrix tests have been successfully run for the following workflow :
• runTheMatrix.py -l 12434.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We target this to go in the next nano production, V14 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

A new Pull Request was created by @JunquanTao for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Mar 6, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Mar 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7cb9f/37919/summary.html
COMMIT: 0dedcaf
CMSSW: CMSSW_14_0_X_2024-03-05-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44325/37919/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 25 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338820
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338766
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.600000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.225 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.150000000000001 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.225 KiB Physics/NanoAODDQM
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.555 2.551 0.004 ( +0.2% ) 5.11 5.20 -1.6% 2.227 2.181
2500.001 2.705 2.700 0.004 ( +0.2% ) 4.66 4.68 -0.3% 2.611 2.600
2500.002 2.646 2.641 0.005 ( +0.2% ) 4.84 4.86 -0.5% 2.607 2.593
2500.01 1.326 1.322 0.004 ( +0.3% ) 9.50 9.66 -1.7% 2.284 2.289
2500.011 1.749 1.745 0.004 ( +0.2% ) 5.16 5.20 -0.7% 2.463 2.458
2500.012 1.590 1.586 0.004 ( +0.3% ) 7.24 7.45 -2.8% 2.396 2.354
2500.1 2.198 2.194 0.004 ( +0.2% ) 5.20 5.31 -1.9% 2.071 2.077
2500.2 2.314 2.310 0.004 ( +0.2% ) 5.94 6.03 -1.4% 1.983 1.981
2500.21 1.190 1.186 0.004 ( +0.4% ) 4.30 4.32 -0.5% 2.268 2.265
2500.211 1.554 1.550 0.005 ( +0.3% ) 3.52 3.69 -4.7% 2.361 2.346
2500.3 2.065 2.061 0.004 ( +0.2% ) 11.98 12.38 -3.2% 1.975 1.975
2500.301 2.639 2.634 0.005 ( +0.2% ) 9.32 10.08 -7.6% 1.964 1.961
2500.31 1.269 1.264 0.004 ( +0.3% ) 18.82 19.89 -5.4% 2.371 2.371
2500.311 1.643 1.638 0.005 ( +0.3% ) 11.70 12.18 -4.0% 2.456 2.451
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.30 1.43 -9.0% 1.698 1.700
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.19 6.37 -2.8% 1.046 1.056
2500.314 1.165 1.161 0.005 ( +0.4% ) 12.12 12.11 +0.1% 2.063 2.112
2500.315 1.763 1.759 0.005 ( +0.3% ) 12.17 11.82 +2.9% 2.329 2.331
2500.4 2.065 2.061 0.004 ( +0.2% ) 12.08 12.62 -4.3% 1.866 1.899
2500.401 1.822 1.818 0.005 ( +0.3% ) 9.85 9.80 +0.5% 1.830 1.824
2500.402 2.639 2.634 0.005 ( +0.2% ) 9.14 9.96 -8.3% 1.837 1.811
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.16 1.03 +13.5% 1.133 1.128

@hqucms
Copy link
Contributor

hqucms commented Mar 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1da5922 into cms-sw:CMSSW_14_0_X Mar 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants