Implementation of TauWPThreshold without need to catch exceptions [13_3_X] #43911

mbluj · 2024-02-08T10:25:02Z

PR description:

As title says, this PR implements parsing of threshold values in the TauWPThreshold class using function which does not require catching exceptions. Namely, it replaces usage of std::stod by std::strtod.
It addresses #39627 independently raised also here #43100 (comment).

Backport of #43890

PR validation:

Identical to #43890 and validated for it.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43890 to 13_3_X release series for consistency of current production release sereies.

cmsbuild · 2024-02-08T10:25:33Z

A new Pull Request was created by @mbluj for CMSSW_13_3_X.

It involves the following packages:

RecoTauTag/RecoTau (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@mbluj, @missirol, @azotz this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Backported from Implementation of TauWPThreshold without need to catch exceptions #43890

cmsbuild · 2024-02-08T10:25:33Z

cms-bot internal usage

mmusich · 2024-02-09T21:11:09Z

@cmsbuild, please test

mmusich · 2024-02-09T21:11:47Z

type tau

cmsbuild · 2024-02-09T23:10:54Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-494f96/37333/summary.html
COMMIT: 25737f9
CMSSW: CMSSW_13_3_X_2024-02-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43911/37333/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestRecoTauTagRecoTau had ERRORS

RelVals

4.53

----- Begin Fatal Exception 09-Feb-2024 22:34:07 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?tried=+1213xrootd-redic.pi.infn.it,&xrdcl.requuid=3e8c40b0-89ec-4fd8-aa04-19d9a8261541
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

136.793

----- Begin Fatal Exception 09-Feb-2024 22:34:11 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2017C/DoubleEG/RAW/v1/000/301/998/00000/0073E73C-B68C-E711-9BF8-02163E019B6C.root?tried=+1213xrootd-redic.pi.infn.it,&xrdcl.requuid=ba4569e9-3749-4ee4-b39c-6fb2c39356b7
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

136.731

----- Begin Fatal Exception 09-Feb-2024 22:34:11 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/007498A6-8426-E611-8BA8-02163E013754.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/007498A6-8426-E611-8BA8-02163E013754.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/007498A6-8426-E611-8BA8-02163E013754.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/007498A6-8426-E611-8BA8-02163E013754.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/007498A6-8426-E611-8BA8-02163E013754.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/007498A6-8426-E611-8BA8-02163E013754.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=377b06ab-4010-438f-a21a-4fe5e39e6416
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.44.4_RunMinBias2012A/step2_RunMinBias2012A.log
4.174.17_RunMinBias2011A/step2_RunMinBias2011A.log
4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log

Expand to see more relval errors ...

AddOn Tests

read312RV

----- Begin Fatal Exception 09-Feb-2024 22:33:31 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2010A/MinimumBias/RAW/v1/000/137/289/B419A444-BD73-DF11-A22C-0030487CD812.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=26a18a79-0f56-4912-b617-8683cfbd9149
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

pat1

----- Begin Fatal Exception 09-Feb-2024 22:33:42 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=32a9cd8d-52ab-4095-a57f-b0d5a2d9dd8c
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

hlt_data_Fake

----- Begin Fatal Exception 09-Feb-2024 22:34:20 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=2bfd549e-13f1-45a7-be21-b211be18724f
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

Martin-Grunewald · 2024-02-10T07:05:42Z

please test

cmsbuild · 2024-02-10T10:04:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-494f96/37336/summary.html
COMMIT: 25737f9
CMSSW: CMSSW_13_3_X_2024-02-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43911/37336/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 153 lines to the logs
Reco comparison results: 21 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3364261
DQMHistoTests: Total failures: 1399
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3362840
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-02-12T08:18:38Z

backport of #43890

mandrenguyen · 2024-02-12T08:19:49Z

+reconstruction

cmsbuild · 2024-02-12T08:20:12Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-02-12T18:11:25Z

+1

Implementation of TauWPThreshold without need to catch exceptions

25737f9

cmsbuild added this to the CMSSW_13_3_X milestone Feb 8, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending labels Feb 8, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 9, 2024

cmsbuild added the tau label Feb 9, 2024

cmsbuild added tests-rejected and removed tests-started labels Feb 9, 2024

cmsbuild added tests-started and removed tests-rejected labels Feb 10, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 10, 2024

cmsbuild added the backport-ok label Feb 12, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 12, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 12, 2024

cmsbuild merged commit df2e167 into cms-sw:CMSSW_13_3_X Feb 12, 2024
10 checks passed

mbluj deleted the CMSSW_13_3_X_tauWPthresholdExceptionFix branch March 13, 2024 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of TauWPThreshold without need to catch exceptions [13_3_X] #43911

Implementation of TauWPThreshold without need to catch exceptions [13_3_X] #43911

mbluj commented Feb 8, 2024

cmsbuild commented Feb 8, 2024 •

edited

Loading

cmsbuild commented Feb 8, 2024 •

edited

Loading

mmusich commented Feb 9, 2024

mmusich commented Feb 9, 2024

cmsbuild commented Feb 9, 2024

Martin-Grunewald commented Feb 10, 2024

cmsbuild commented Feb 10, 2024

mandrenguyen commented Feb 12, 2024

mandrenguyen commented Feb 12, 2024

cmsbuild commented Feb 12, 2024

antoniovilela commented Feb 12, 2024

Implementation of TauWPThreshold without need to catch exceptions [13_3_X] #43911

Implementation of TauWPThreshold without need to catch exceptions [13_3_X] #43911

Conversation

mbluj commented Feb 8, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 8, 2024 • edited Loading

cmsbuild commented Feb 8, 2024 • edited Loading

mmusich commented Feb 9, 2024

mmusich commented Feb 9, 2024

cmsbuild commented Feb 9, 2024

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

Martin-Grunewald commented Feb 10, 2024

cmsbuild commented Feb 10, 2024

Comparison Summary

mandrenguyen commented Feb 12, 2024

mandrenguyen commented Feb 12, 2024

cmsbuild commented Feb 12, 2024

antoniovilela commented Feb 12, 2024

cmsbuild commented Feb 8, 2024 •

edited

Loading

cmsbuild commented Feb 8, 2024 •

edited

Loading