TauWPThreshold uses exceptions in string parsing

[makortel]

The deep_tau::TauWPThreshold constructor uses exceptions string parsing

cmssw/RecoTauTag/RecoTau/src/DeepTauBase.cc

Lines 19 to 25 in bae128c

	try {
	size_t pos = 0;
	value_ = std::stod(cut_str, &pos);
	simple_value = (pos == cut_str.size());
	} catch (std::invalid_argument&) {
	} catch (std::out_of_range&) {
	}

I encountered this exception being thrown many times (don't know how many because I gave up) when trying to catch a different exception, so the parse error does not seem to be as exceptional that exceptions would be justified (see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEdmExceptionUse#Exception_Handling,
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Re-throw
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Re-errors)

I'd suggest to parse the string in a way that does not use exceptions to signal an invalid value. E,g, std::from_chars() looks like a good candidate, but GCC (or libstdc++) implements it for floating point numbers only in version 11 (to which we'll hopefully switch to soon). An alternative could be std::strtod (from C) or std::istringstream (expensive).

[makortel]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@mandrenguyen,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[clacaputo]

type tau

@cms-sw/tau-pog-l2

[kandrosov]

Since parsing occurs only at the initialisation stage, I think std::istringstream is a best option for now. Once std::from_chars is available - we can switch to it.