Implementation of TauWPThreshold without need to catch exceptions

[mbluj]

PR description:

As title says, this PR implements parsing of threshold values in the TauWPThreshold class using function which does not require catching exceptions. Namely it replaces usage of std::stod by std::strtod.
It addresses #39627 independently raised also here #43100 (comment).

Q: I guess it should be backported - to which release series?

PR validation:

Checked with a custom workflow that new implementation of TauWPThreshold behaves as expected for simple numbers, expressions and incorrect expressions.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43890/38748

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• RecoTauTag/RecoTau (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@mbluj, @azotz, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mbluj]

FYI, @kandrosov, @fwyzard, @mmusich

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d49615/37279/summary.html
COMMIT: c6d18fd
CMSSW: CMSSW_14_1_X_2024-02-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43890/37279/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 100 lines to the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 1186
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247418
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fwyzard]

@mbluj @kandrosov thanks for the quick fix 👍🏻

[mbluj]

Shoud it be backported? Which release series are going to be used to test and then run HLT in 2024?

[mmusich]

Shoud it be backported? Which release series are going to be used to test and then run HLT in 2024?

@mbluj, minimally, please backport it to CMSSW_14_0_X (which is the current operations release this year). CMSSW_13_3_X would be good for internal consistency, but not strictly necessary.

[mandrenguyen]

+reconstruction
Agree we should backport to 14_0_X.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

type tau

[rappoccio]

+1