Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X SIM] Backport of ZDC transport modifier for heavy ion simulation modifier #43494

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 5, 2023

PR description:

Backport of #43493, which extend modifier for heavy ion FullSim for Run3. SHould not affect any pp workflow.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport from 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_13_0_X.

It involves the following packages:

  • SimG4Core/Application (simulation)

@mdhildreth, @cmsbuild, @civanch can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @bsunanda, @makortel, @rovere this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Dec 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e9ec4/36330/summary.html
COMMIT: 38df996
CMSSW: CMSSW_13_0_X_2023-12-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43494/36330/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 983
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282615
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Dec 5, 2023

+1

The regression is broken in MkFit WF only and is full in all other WFs, so pp Run-3 is not affected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

Pull request #43494 was updated. @mdhildreth, @civanch, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

Pull request #43494 was updated. @civanch, @mdhildreth, @cmsbuild can you please check and sign again.

@civanch
Copy link
Contributor Author

civanch commented Dec 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e9ec4/36341/summary.html
COMMIT: 9d07d2f
CMSSW: CMSSW_13_0_X_2023-12-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43494/36341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor Author

civanch commented Dec 5, 2023

+1

The regression is broken only in one MkFit WF, which is known. So, pp Run-3 is not affected as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

The 14_0_0 version is not signed by simulation, @cms-sw/simulation-l2 can you please sign that?

@civanch
Copy link
Contributor Author

civanch commented Dec 7, 2023

@rappoccio , 14_0_X PR is OK now.

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4349009 into cms-sw:CMSSW_13_0_X Dec 11, 2023
10 checks passed
civanch added a commit to civanch/cmssw that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants