-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13_0_X SIM] Backport of ZDC transport modifier for heavy ion simulation modifier #43494
[13_0_X SIM] Backport of ZDC transport modifier for heavy ion simulation modifier #43494
Conversation
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_13_0_X. It involves the following packages:
@mdhildreth, @cmsbuild, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e9ec4/36330/summary.html Comparison SummarySummary:
|
+1 The regression is broken in MkFit WF only and is full in all other WFs, so pp Run-3 is not affected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Pull request #43494 was updated. @mdhildreth, @civanch, @cmsbuild can you please check and sign again. |
Pull request #43494 was updated. @civanch, @mdhildreth, @cmsbuild can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e9ec4/36341/summary.html Comparison SummarySummary:
|
+1 The regression is broken only in one MkFit WF, which is known. So, pp Run-3 is not affected as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
The 14_0_0 version is not signed by simulation, @cms-sw/simulation-l2 can you please sign that? |
@rappoccio , 14_0_X PR is OK now. |
+1 |
PR description:
Backport of #43493, which extend modifier for heavy ion FullSim for Run3. SHould not affect any pp workflow.
PR validation:
private
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport from 14_0_X