Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_HeavyIons_X SIM] Backport of ZDC simulation #43554

Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 12, 2023

PR description:

Backport of ZDC simulation and modifier for heavy ion #43493, which extend modifier for heavy ion FullSim for Run3. It is the same as #43494 in 13_0_X. This PR should not affect any pp workflow.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: provide ZDC simulation for PbPb run

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2023

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_13_0_HeavyIon_X.

It involves the following packages:

  • SimG4CMS/Forward (simulation)
  • SimG4Core/Application (simulation)

@mdhildreth, @civanch, @cmsbuild can you please review it and eventually sign? Thanks.
@rovere, @makortel, @slomeo, @bsunanda, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@civanch civanch changed the title copy #43494 [13_0_HeavyIons_X SIM] Backport of ZDC simulation Dec 12, 2023
@civanch
Copy link
Contributor Author

civanch commented Dec 12, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64df7d/36441/summary.html
COMMIT: 3ca07eb
CMSSW: CMSSW_13_0_HeavyIon_X_2023-12-10-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43554/36441/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor Author

civanch commented Dec 12, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_HeavyIon_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor Author

civanch commented Dec 13, 2023

urgent

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4d918a6 into cms-sw:CMSSW_13_0_HeavyIon_X Dec 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants