Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X SIM] Backport for ZDC simulation #43483

Closed
wants to merge 1 commit into from

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 3, 2023

PR description:

This backport is strongly needed in order to allow n, nbar, and gamma reach ZDC. This is needed for HI production.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_13_0_X.

It involves the following packages:

  • SimG4Core/Application (simulation)

@mdhildreth, @civanch, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @fabiocos, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Dec 3, 2023

please test

@civanch
Copy link
Contributor Author

civanch commented Dec 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c34f/36283/summary.html
COMMIT: 460d8fa
CMSSW: CMSSW_13_0_X_2023-12-03-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43483/36283/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 254 lines from the logs
  • Reco comparison results: 16034 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 307139
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2976459
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.938 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 0.938 KiB SiStrip/MechanicalView
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 4 / 47 workflows

@civanch
Copy link
Contributor Author

civanch commented Dec 3, 2023

Simulation of ZDC change simulation histories, so no regression.

@antoniovilela
Copy link
Contributor

hold

  • Hold integration in 13_0_X as this is intended for CMSSW_13_0_HeavyIon_X .

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@civanch
Copy link
Contributor Author

civanch commented Dec 7, 2023

#43494 should be used.

@civanch civanch closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants