Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import NanoAOD-tools postoprocessor to CMSSW [13.0.X] #43394

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

namapane
Copy link
Contributor

PR description:

Plain backport of #42323 (addressing #43379).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_13_0_X.

It involves the following packages:

  • DataFormats/Math (reconstruction)
  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/NanoAODTools (xpog)

@mandrenguyen, @vlimant, @simonepigazzini, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@felicepantaleo, @makortel, @fabiocos, @rovere, @lenzip, @AnnikaStein, @clelange, @missirol, @gpetruc this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-619971/36128/summary.html
COMMIT: 9eef8d2
CMSSW: CMSSW_13_0_X_2023-11-26-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43394/36128/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@vlimant
Copy link
Contributor

vlimant commented Dec 1, 2023

is this good to sign @clelange @lenzip ?

@clelange
Copy link
Contributor

clelange commented Dec 1, 2023

is this good to sign @clelange @lenzip ?

Yes, thanks for checking!

@vlimant
Copy link
Contributor

vlimant commented Dec 4, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce34e99 into cms-sw:CMSSW_13_0_X Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants