Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import NanoAOD-tools postoprocessor to CMSSW #42323

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

namapane
Copy link
Contributor

PR description:

Addressing #41839, this PR imports the posprocessor functionality of cms-nanoAOD/nanoAOD-tools (without obsolete correction modules) into CMSSW.
Compared to the original version, the following changes have been made:

  • dropped of all correction modules, which are obsolete and, if needded, should be replaced with correctionlib-based modules to be stored in an external repository;
  • removed functionality that is already present in CMSSW; in particular, take ReduceMantissaToNbitsRounding from DataFormats/Math (dictionaries added therein for this purpose);
  • minimal updates for python3;
  • reorganized examples according to CMSSW standards; in particular, move example scripts and lib to test/ (and add some basic comments)
  • Small update to allow passin branchsel as a list (and not just as a filename);
  • Adapted the standalone checkout scripts to allow a sparse shallow clone of the package;
  • Updated README.md to reflect the above modifications.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42323/36350

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @namapane (Nicola Amapane) for master.

It involves the following packages:

  • DataFormats/Math (reconstruction)
  • PhysicsTools/NanoAODTools (****)

The following packages do not have a category, yet:

PhysicsTools/NanoAODTools
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere, @missirol, @AnnikaStein, @gpetruc, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42323/36403

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42323 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

@clacaputo
Copy link
Contributor

assign xpog

@clacaputo
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

New categories assigned: xpog

@simonepigazzini,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0998fb/33979/summary.html
COMMIT: c629c0b
CMSSW: CMSSW_13_3_X_2023-07-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42323/33979/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 3636 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 4316
  • DQMHistoTests: Total nulls: 55
  • DQMHistoTests: Total successes: 3146428
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42323/37124

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

Pull request #42323 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0998fb/35086/summary.html
COMMIT: 347bd36
CMSSW: CMSSW_13_3_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42323/35086/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356892
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

@smuzaffar
Hi Malik, everything ok from your side?

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 6b7efc8 into cms-sw:master Oct 9, 2023
@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@antoniovilela
Copy link
Contributor

Close #41839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.