Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First examples and instructions #1

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Conversation

IzaakWN
Copy link
Collaborator

@IzaakWN IzaakWN commented Nov 21, 2023

Hi @ttedeschi, here are the first examples plus instructions. I talked with @namapane, and we agreed to structure the repo as an independent CMSSW module so it can be added in parallel to any version of nanoAOD-tools.

I did not have time to finish the tau module, which is a bit more complicated, but I will add it in a later. After that we can also add things like a pileup module.

README.md Outdated
```

### Install `nanoAOD-tools`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would somehow make it clearer directly in the subtitles of the README.md that the installation of NanoAOD-tools is required only in case of older CMSSW versions (and discouraged).

something like:

Install nanoAOD-tools (only necessary for CMSSW versions < 1X.X)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed version to "CMSSW 13.2 or older" and "from CMSSW 13.3":
https://github.com/IzaakWN/nanoAOD-tools-modules/tree/master#install-nanoaod-tools-for-cmssw-132-or-older
Hope we're converging on the CMSSW version. 😛

@ttedeschi
Copy link
Contributor

ttedeschi commented Dec 21, 2023

NanoAOD-tools has been backported to 13.1 and 13.0 cms-sw/cmssw#43393 cms-sw/cmssw#43394 @IzaakWN please modify the README according to this then I think we can merge

@namapane
Copy link
Collaborator

NanoAOD-tools has been backported to 13.1 and 13.0 cms-sw/cmssw#43393 cms-sw/cmssw#43394 @IzaakWN please modify the README according to this then I think we can merge

Specifically, it has been included in besides 13_3_0 and 13_0_16.
Regarding 13_1_X, it has been merged, but no release has been made since, so it should enter in 13_1_5, if that release is created at some point.
It may be safe enough to mention 13_0_16, 13_1_5 and 13_3_0 in the doc anyhow.

I also wonder if it would not make sense to add documentation in the github wiki (which is not activated) and add a link in the README.md. This would allow us to expand the documentation without having to make a PR each time. What do you think?

@ttedeschi
Copy link
Contributor

Fine for me, I activated the wiki and added you Nicola as a maintainer

@ttedeschi ttedeschi merged commit 15986bc into cms-cat:master Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants