-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First examples and instructions #1
Conversation
README.md
Outdated
``` | ||
|
||
### Install `nanoAOD-tools` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would somehow make it clearer directly in the subtitles of the README.md that the installation of NanoAOD-tools is required only in case of older CMSSW versions (and discouraged).
something like:
Install nanoAOD-tools
(only necessary for CMSSW versions < 1X.X)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed version to CMSSW 12.6:
https://github.com/IzaakWN/nanoAOD-tools-modules/tree/master#install-nanoaod-tools-for-cmssw-126-or-older
Hope this is more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed version to "CMSSW 13.2 or older" and "from CMSSW 13.3":
https://github.com/IzaakWN/nanoAOD-tools-modules/tree/master#install-nanoaod-tools-for-cmssw-132-or-older
Hope we're converging on the CMSSW version. 😛
NanoAOD-tools has been backported to 13.1 and 13.0 cms-sw/cmssw#43393 cms-sw/cmssw#43394 @IzaakWN please modify the README according to this then I think we can merge |
Specifically, it has been included in besides 13_3_0 and 13_0_16. I also wonder if it would not make sense to add documentation in the github wiki (which is not activated) and add a link in the README.md. This would allow us to expand the documentation without having to make a PR each time. What do you think? |
Fine for me, I activated the wiki and added you Nicola as a maintainer |
Hi @ttedeschi, here are the first examples plus instructions. I talked with @namapane, and we agreed to structure the repo as an independent CMSSW module so it can be added in parallel to any version of nanoAOD-tools.
I did not have time to finish the tau module, which is a bit more complicated, but I will add it in a later. After that we can also add things like a pileup module.