(Backport) Adding L1 unprefirable event info and Final OR decision in BX-1/-2

[lathomas]

PR description:

This PR adds four booleans to NANOAOD (L1_UnprefireableEvent_TriggerRules, L1_UnprefireableEvent_FirstBxInTrain, L1_FinalOR_BXmin1, L1_FinalOR_BXmin2) related to L1T prefiring studies.
This is a backport of #43306 and #43150

[cmsbuild]

A new Pull Request was created by @lathomas for CMSSW_13_3_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@vlimant, @simonepigazzini, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[simonepigazzini]

enable nano

[simonepigazzini]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cd414/36054/summary.html
COMMIT: f16bd24
CMSSW: CMSSW_13_3_X_2023-11-24-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43387/36054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 294 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 140 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3362836
• DQMHistoTests: Total failures: 1792
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361022
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16335
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16335
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.539	2.539	0.000 ( +0.0% )	5.31	5.35	-0.8%	2.108	2.056
2500.001	2.686	2.685	0.001 ( +0.0% )	4.79	4.81	-0.3%	2.133	2.444
2500.002	2.622	2.622	0.000 ( +0.0% )	4.95	4.98	-0.5%	2.146	2.448
2500.01	1.310	1.310	0.000 ( +0.0% )	9.91	9.76	+1.5%	2.244	2.151
2500.011	1.726	1.726	0.000 ( +0.0% )	5.32	5.17	+3.0%	2.047	2.283
2500.012	1.572	1.572	0.000 ( +0.0% )	7.65	7.43	+3.0%	2.352	2.221
2500.1	2.190	2.190	-0.000 ( -0.0% )	5.38	5.38	-0.0%	1.971	1.983
2500.2	2.301	2.301	0.000 ( +0.0% )	6.15	6.19	-0.5%	1.898	1.898
2500.21	1.177	1.177	0.000 ( +0.0% )	4.42	4.46	-1.0%	1.874	2.173
2500.211	1.540	1.539	0.001 ( +0.0% )	3.90	3.90	-0.1%	1.970	2.252
2500.3	2.057	2.056	0.000 ( +0.0% )	12.94	12.93	+0.1%	1.889	1.884
2500.31	1.253	1.253	0.000 ( +0.0% )	20.52	20.79	-1.3%	2.284	2.255
2500.311	1.639	1.639	0.001 ( +0.0% )	14.56	14.50	+0.4%	2.356	2.328
2500.4	2.057	2.056	0.000 ( +0.0% )	12.93	12.62	+2.4%	1.887	1.886
2500.5	19.575	19.544	0.031 ( +0.2% )	1.32	1.20	+10.8%	1.302	1.294

[lathomas]

Hello. A kind reminder to @vlimant @simonepigazzini It would be really great to have this integrated for the next reNANO campaign.
Thank you very much.

[jordan-martins]

Hi @cms-sw/xpog-l2 ,

lets have that included, please.

Thanks,
PPD
FYI @cms-sw/ppd-l2

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1